-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refa(listbox): Allow sections in Combobox + Autocomplete, adjust Section API #4187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fa987ec The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
github-actions
bot
added
type:docs
Improvements or additions to documentation
type:feature
New feature or component
labels
Oct 1, 2024
Coverage report
Show files with reduced coverage 🔻
Test suite run success572 tests passing in 78 suites. Report generated by 🧪jest coverage report action from fa987ec |
1 task
aromko
reviewed
Oct 4, 2024
sarahgm
approved these changes
Oct 7, 2024
aromko
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🚨 Breacking Change
type:docs
Improvements or additions to documentation
type:feature
New feature or component
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This PR contains a breaking change! See below. This should be merged with #4164
Description
Added the possibility to use sections with
Combobox
andAutocomplete
Refactored the
Section
(fromListbox
) to fit our API, no need for the extraHeader
anymore. Instead you can do<Select.Section header="My header">
, same for the other componentsRenamed
Item
toOption
inCombobox
andAutocomplete
to align withSelect
Updated the docs for
Select
,Combobox
andAutocomplete
Updated Storybook for
Select
,Combobox
andAutocomplete
with section storiesRequires a change in the UI kit @tirado-rx
What should be tested?
Using sections with
Select
,Combobox
andAutocomplete
Are they some special informations required to test something?
nope.
Reviewers:
@marigold-ui/developer
@marigold-ui/designer
Closes DSTSUP-89