Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refa(listbox): Allow sections in Combobox + Autocomplete, adjust Section API #4187

Merged
merged 12 commits into from
Oct 10, 2024

Conversation

sebald
Copy link
Member

@sebald sebald commented Oct 1, 2024

Warning

This PR contains a breaking change! See below. This should be merged with #4164

Description

  • Added the possibility to use sections with Combobox and Autocomplete

  • Refactored the Section (from Listbox) to fit our API, no need for the extra Header anymore. Instead you can do <Select.Section header="My header">, same for the other components

  • Renamed Item to Option in Combobox and Autocomplete to align with Select

  • Updated the docs for Select, Combobox and Autocomplete

  • Updated Storybook for Select, Combobox and Autocomplete with section stories

  • Requires a change in the UI kit @tirado-rx

What should be tested?

Using sections with Select, Combobox and Autocomplete

Are they some special informations required to test something?

nope.

Reviewers:

@marigold-ui/developer
@marigold-ui/designer

Closes DSTSUP-89

Copy link

changeset-bot bot commented Oct 1, 2024

🦋 Changeset detected

Latest commit: fa987ec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@marigold/docs Patch
@marigold/components Patch
@marigold/system Patch
@marigold/theme-b2b Patch
@marigold/storybook-config Patch
@marigold/theme-core Patch
@marigold/theme-docs Patch
@marigold/icons Patch
@marigold/theme-preset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marigold-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 6:57am
marigold-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 6:57am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
marigold-production ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 6:57am

@github-actions github-actions bot added type:docs Improvements or additions to documentation type:feature New feature or component labels Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
99.62% (-0.01% 🔻)
7836/7866
🟢 Branches
88.74% (-0.89% 🔻)
339/382
🟢 Functions 98.44% 126/128
🟢 Lines
99.62% (-0.01% 🔻)
7836/7866
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / Checkbox.tsx
98.33%
66.67% (-23.33% 🔻)
100% 98.33%
🟢
... / Input.tsx
98.72% (-1.28% 🔻)
80% (-20% 🔻)
100%
98.72% (-1.28% 🔻)

Test suite run success

572 tests passing in 78 suites.

Report generated by 🧪jest coverage report action from fa987ec

@aromko aromko merged commit caefbe4 into main Oct 10, 2024
15 checks passed
@aromko aromko deleted the DSTSUP-89-combobox-section branch October 10, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 Breacking Change type:docs Improvements or additions to documentation type:feature New feature or component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants