2048 the game #422
2048 the game #422
Conversation
| return Math.random() < 0.9 ? 2 : 4; | ||
| } | ||
|
|
||
| function newCell() { |
There was a problem hiding this comment.
The condition 'clearCells.length === undefined' can be simplified to '!clearCells.length' which checks if the array is empty or not.
src/scripts/main.js
Outdated
|
|
||
| switch (direction) { | ||
| case 'ArrowUp': | ||
| for (const column of columns) { |
There was a problem hiding this comment.
Avoid using a for...of loop to iterate over an array. Instead, use forEach or map.
src/scripts/main.js
Outdated
| }); | ||
| } | ||
|
|
||
| document.addEventListener('keyup', (evnt) => { |
There was a problem hiding this comment.
It's more efficient to listen to the keyup event only on the window or document object, not on the entire document. So you can change 'document.addEventListener' to 'window.addEventListener' or 'document.body.addEventListener'.
There was a problem hiding this comment.
I've decided to change it back to 'keydown'. It feels more natural and more responsive while playing.
src/scripts/main.js
Outdated
| function canBeMarged() { | ||
| const wholeField = [...cellsInRow, ...columns]; | ||
|
|
||
| for (const line of wholeField) { |
There was a problem hiding this comment.
Avoid using a for...of loop to iterate over an array. Instead, use forEach or map.
src/scripts/main.js
Outdated
| } | ||
|
|
||
| switch (direction) { | ||
| case 'ArrowUp': |
There was a problem hiding this comment.
Сreate a variable for these magic words
| case left: | ||
| cellsInRow.forEach((row) => { | ||
| flipLine([...row].reverse()); | ||
| }); | ||
| break; |
There was a problem hiding this comment.
Switch case should always have default case to handle possible errors
DEMO LINK
I've decided to use "keyup" event instead of "keydown" just in case to avoid continuous moves if press and hold any arrow key. Also, I`ve changed UI a little and added some sound effects for a better experience.
p.s. During development I have never won the game, maybe you will have more luck ;)