created several Figure and color classes and their suppliers #1729

VasylAzarov · 2024-11-01T14:20:50Z

No description provided.

mateacademy-ai-mentor

Thank you for your hard work on this project! While your code is mostly on the right track, there are a few critical issues that need to be addressed before we can approve the pull request:

Area Calculation Errors: The calculateArea() methods in both the Circle and RightTriangle classes have inaccuracies. For the Circle, casting Math.PI to an int leads to a loss of precision. Similarly, the RightTriangle area calculation does not use the correct formula. Consider using double for more precise calculations.
Enum Usage: It's recommended to use the Color and FigureName enums directly instead of converting them to String. This will enhance type safety and align with the intended use of enums.
Return Type in ColorSupplier: The getRandomColor method currently returns a String, but it would be more appropriate to return a Color type directly. This change will better utilize the Color enum.

These changes are necessary to ensure the functionality and accuracy of your code. Keep up the great work, and I'm confident you'll address these issues swiftly! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

src/main/java/core/basesyntax/Circle.java

src/main/java/core/basesyntax/ColorSupplier.java

src/main/java/core/basesyntax/FigureSupplier.java

src/main/java/core/basesyntax/IsoscelesTrapezoid.java

src/main/java/core/basesyntax/RightTriangle.java

mateacademy-ai-mentor

Your code has been reviewed and approved! 🎉 While there are some areas for improvement, the overall implementation meets the task requirements. Here are some key points to consider for future enhancements:

Magic Numbers: Avoid using magic numbers directly in your code. Define them as constants for better readability and maintainability.
FigureSupplier Instance: Create the FigureSupplier instance once before the loop in the Main class to optimize performance.
Constructor Expressions: Assign expressions to variables before passing them to constructors to enhance code clarity.
Class-Level Variables: Consider making the Random instance in FigureSupplier a class-level variable to avoid multiple instantiations.
Abstract Class: If Figure is not meant to be instantiated directly, consider making it an abstract class.
Enum Usage: Use the Color and FigureName enums directly to maintain type safety and consistency.
Precision in Calculations: Use double for calculations in calculateArea methods to prevent precision loss.
Formatting: Ensure proper formatting in toString methods and remove any unnecessary characters like extra commas.

These improvements will help you write cleaner and more efficient code. Keep up the great work, and continue learning from these suggestions! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

mateacademy-ai-mentor · 2024-11-04T09:27:08Z

src/main/java/core/basesyntax/Circle.java

+    public int calculateArea() {
+        return (int) (radius * radius * Math.PI);


The calculateArea method returns an int, but the area of a circle is a double value due to the use of Math.PI. Consider changing the return type to double to avoid loss of precision.

mateacademy-ai-mentor · 2024-11-04T09:27:09Z

src/main/java/core/basesyntax/ColorSupplier.java

+    public String getRandomColor() {
+        Color[] values = Color.values();
+        int randomIndex = new Random().nextInt(values.length);
+        return values[randomIndex].name();


Consider changing the return type of getRandomColor from String to Color to maintain consistency with the Color enum. This will allow you to work directly with the Color type instead of converting it to a String.

mateacademy-ai-mentor · 2024-11-04T09:27:09Z

src/main/java/core/basesyntax/Figure.java

@@ -0,0 +1,51 @@
+package core.basesyntax;
+
+public class Figure implements AreaCalculator {


Consider making Figure an abstract class if it is intended to serve as a base class for other specific figure types like Circle. This would prevent direct instantiation of Figure and emphasize that it is meant to be extended.

mateacademy-ai-mentor · 2024-11-04T09:27:09Z

src/main/java/core/basesyntax/FigureSupplier.java

+            case 2 -> randomFigure = getRandomRectangle();
+            case 3 -> randomFigure = getRightTriangle();
+            case 4 -> randomFigure = getRandomSquare();
+            default -> randomFigure = new Figure();


The default case in the switch statement creates a new Figure object. If Figure is intended to be an abstract class or should not be instantiated directly, consider removing this default case or handling it differently.

mateacademy-ai-mentor · 2024-11-04T09:27:09Z

src/main/java/core/basesyntax/FigureSupplier.java

+    }
+
+    public Figure getDefaultFigure() {
+        return new Circle(Color.WHITE.name(), FigureName.CIRCLE.name(), 10);


Consider using the Color and FigureName enums directly instead of calling name(). This will maintain type safety and consistency with the enum usage.

mateacademy-ai-mentor · 2024-11-04T09:27:10Z

src/main/java/core/basesyntax/Main.java

+    public static void main(String[] args) {
+        Figure[] figures = new Figure[6];
+        for (int i = 0; i < 3; i++) {
+            figures[i] = new FigureSupplier().getRandomFigure();


Ensure that FigureSupplier.getRandomFigure() does not return a direct instance of Figure if Figure is intended to be a base class or abstract. This aligns with the suggestion to make Figure an abstract class.

mateacademy-ai-mentor · 2024-11-04T09:27:10Z

src/main/java/core/basesyntax/Rectangle.java

+    private int firstLag;
+    private int secondLag;


The variable names firstLag and secondLag might be confusing. Consider renaming them to width and height or length and breadth for better clarity and understanding.

mateacademy-ai-mentor · 2024-11-04T09:27:10Z

src/main/java/core/basesyntax/RightTriangle.java

+    public int calculateArea() {
+        return (int) (Math.pow(firstLag, 2) * (Math.sqrt(3)) / 4);


The formula used in calculateArea is for an equilateral triangle, not a right triangle. For a right triangle, the area should be calculated as (base * height) / 2. Ensure that the correct dimensions are used for a right triangle.

mateacademy-ai-mentor · 2024-11-04T09:27:10Z

src/main/java/core/basesyntax/RightTriangle.java

+package core.basesyntax;
+
+public class RightTriangle extends Figure {
+    private int firstLag;


The variable name firstLag might be confusing. Consider renaming it to base or height for better clarity and understanding, especially since this is a right triangle.

mateacademy-ai-mentor · 2024-11-04T09:27:10Z

src/main/java/core/basesyntax/Square.java

+package core.basesyntax;
+
+public class Square extends Figure {
+    private int firstLag;


The variable name firstLag might be confusing. Consider renaming it to side for better clarity and understanding, as it represents the side length of the square.

created several Figure and color classes and their suppliers

ef09d43

mateacademy-ai-mentor suggested changes Nov 1, 2024

View reviewed changes

VasylAzarov added 8 commits November 1, 2024 15:24

update code style

53f9913

update code style 2

934604d

update code style 3

12cba27

update code style 4

9ab5bf8

update code style 5

74547db

update code style 6

42293b5

update code style 7

1252a82

update code style 8

9036275

VasylAzarov requested a review from mateacademy-ai-mentor November 4, 2024 09:24

mateacademy-ai-mentor approved these changes Nov 4, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

created several Figure and color classes and their suppliers #1729

created several Figure and color classes and their suppliers #1729

VasylAzarov commented Nov 1, 2024

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor Nov 4, 2024

mateacademy-ai-mentor Nov 4, 2024

mateacademy-ai-mentor Nov 4, 2024

mateacademy-ai-mentor Nov 4, 2024

mateacademy-ai-mentor Nov 4, 2024

mateacademy-ai-mentor Nov 4, 2024

mateacademy-ai-mentor Nov 4, 2024

mateacademy-ai-mentor Nov 4, 2024

mateacademy-ai-mentor Nov 4, 2024

mateacademy-ai-mentor Nov 4, 2024

		public int calculateArea() {
		return (int) (radius * radius * Math.PI);

		@@ -0,0 +1,51 @@
		package core.basesyntax;

		public class Figure implements AreaCalculator {

		public int calculateArea() {
		return (int) (Math.pow(firstLag, 2) * (Math.sqrt(3)) / 4);

created several Figure and color classes and their suppliers #1729

Are you sure you want to change the base?

created several Figure and color classes and their suppliers #1729

Conversation

VasylAzarov commented Nov 1, 2024

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment