Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
created several Figure and color classes and their suppliers #1729
base: master
Are you sure you want to change the base?
created several Figure and color classes and their suppliers #1729
Changes from 1 commit
ef09d43
53f9913
934604d
12cba27
9ab5bf8
74547db
42293b5
1252a82
9036275
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an extra comma before the 'color' field in the
toString
method. Consider removing it for better formatting.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that
FigureSupplier.getRandomFigure()
does not return a direct instance ofFigure
ifFigure
is intended to be a base class or abstract. This aligns with the suggestion to makeFigure
an abstract class.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable names
firstLag
andsecondLag
might be confusing. Consider renaming them towidth
andheight
orlength
andbreadth
for better clarity and understanding.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable name
firstLag
might be confusing. Consider renaming it tobase
orheight
for better clarity and understanding, especially since this is a right triangle.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable name
firstLag
might be confusing. Consider renaming it toside
for better clarity and understanding, as it represents the side length of the square.