implement py-cache-decorator #1397
Conversation
There was a problem hiding this comment.
Great job on implementing the cache decorator! 🎉 The functionality is solid, and it meets all the core requirements of the task. The only minor suggestion is to adjust the return type hint of the wrapper function to better reflect the return type of the decorated function. This will enhance code clarity and maintainability. Keep up the excellent work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
app/main.py
Outdated
| pass | ||
| cache_args = {} | ||
|
|
||
| def wrapper(*args, **kwargs) -> Callable: |
There was a problem hiding this comment.
The return type hint for the wrapper function is currently Callable, which is not accurate. Since wrapper returns the result of func(*args, **kwargs), the return type hint should match the return type of func. Consider changing it to Any if the return type of func is not known, or use a more specific type if possible.
No description provided.