Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement py-cache-decorator #1397

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

implement py-cache-decorator #1397

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c6eaae
implement py-cache-decorator
muriakula Nov 12, 2024
afda566
return type for wrapper has been changed
muriakula Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,14 @@


def cache(func: Callable) -> Callable:
# Write your code here
pass
cache_args = {}

def wrapper(*args, **kwargs) -> Callable:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type hint for the wrapper function is currently Callable, which is not accurate. Since wrapper returns the result of func(*args, **kwargs), the return type hint should match the return type of func. Consider changing it to Any if the return type of func is not known, or use a more specific type if possible.

key = (args, tuple(kwargs.items()))
if key in cache_args:
print("Getting from cache")
else:
print("Calculating new result")
cache_args[key] = func(*args, **kwargs)
return cache_args[key]
return wrapper
Loading