Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1636

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #1636

wants to merge 1 commit into from

Conversation

lurd22
Copy link

@lurd22 lurd22 commented Nov 13, 2024

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Great job on implementing the Car and CarWashStation classes! 🎉 Your code meets the task requirements and constraints effectively. The methods are well-structured and adhere to the guidelines provided.

One minor suggestion: In the serve_cars method, the line car.clean_mark = self.wash_single_car() might be a bit misleading. The wash_single_car method returns self.clean_power, which may not directly represent the car's new clean mark. It could be beneficial to adjust the car's clean mark based on a more realistic washing effect or clarify the logic if this is intentional.

Keep up the great work, and happy coding! 🚗🧼

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +36 to +38
car_income = self.calculate_washing_price(car)
price += car_income
car.clean_mark = self.wash_single_car()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the serve_cars method, the line car.clean_mark = self.wash_single_car() is misleading. The wash_single_car method returns self.clean_power, which is not necessarily the new clean mark of the car. Consider updating the car's clean mark based on a more realistic washing effect, or clarify the logic if this is intentional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants