Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1636

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 58 additions & 4 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,62 @@
class Car:
# write your code here
pass
def __init__(
self,
comfort_class: int,
clean_mark: int,
brand: str
) -> None:

self.comfort_class = comfort_class
self.clean_mark = clean_mark
self.brand = brand


class CarWashStation:
# write your code here
pass
def __init__(
self,
distance_from_city_center: float,
clean_power: int,
average_rating: float,
count_of_ratings: int,
) -> None:

self.distance_from_city_center = distance_from_city_center
self.clean_power = clean_power
self.average_rating = average_rating
self.count_of_ratings = count_of_ratings

def serve_cars(self, cars: list) -> float:

price = 0.0

for car in cars:

if car.clean_mark < self.clean_power:

car_income = self.calculate_washing_price(car)
price += car_income
car.clean_mark = self.wash_single_car()
Comment on lines +36 to +38

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the serve_cars method, the line car.clean_mark = self.wash_single_car() is misleading. The wash_single_car method returns self.clean_power, which is not necessarily the new clean mark of the car. Consider updating the car's clean mark based on a more realistic washing effect, or clarify the logic if this is intentional.


return round(price, 1)

def calculate_washing_price(self, car: Car) -> float:

clean_diff = self.clean_power - car.clean_mark
car_income = (
car.comfort_class * clean_diff * self.average_rating
) / self.distance_from_city_center
return round(car_income, 1)

def wash_single_car(self) -> int:

return self.clean_power

def rate_service(self, single_rate: float) -> None:

new_rating = round(
(self.average_rating * self.count_of_ratings + single_rate)
/ (self.count_of_ratings + 1),
1,
)
self.count_of_ratings += 1
self.average_rating = new_rating
Loading