Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] proxy: current way of detecting txn status is not robust #10486

Merged
merged 5 commits into from
Jul 7, 2023
Merged

[bug] proxy: current way of detecting txn status is not robust #10486

merged 5 commits into from
Jul 7, 2023
+372 −360

Commits on Jul 7, 2023

  1. [bug] proxy: current way of detecting txn status is not robust 

    Reason: current way of detecting a connection is in active txn
or not is by parse the SQL statement from client. If it matches
begin, commit or rollback, we change the txn status. This way is
not robust, because the statement may contains some comment strings.

Fix: check the txn status by the OK and EOF packet returned from server.
Those packets contains the txn status. But currently, MO server
does not set the status in OK and EOF packets correctly. So first,
set the correty status in OK and EOF packets, then set the txn status
in proxy session.
    @volgariver6
    volgariver6 committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    b0c5821 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into issue10015

    @volgariver6
    volgariver6 authored Jul 7, 2023
    Configuration menu
    Copy the full SHA
    86788e6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into issue10015

    @volgariver6
    volgariver6 authored Jul 7, 2023
    Configuration menu
    Copy the full SHA
    3779a4a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into issue10015

    @volgariver6
    volgariver6 authored Jul 7, 2023
    Configuration menu
    Copy the full SHA
    39264e0 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into issue10015

    @mergify
    mergify[bot] authored Jul 7, 2023
    Configuration menu
    Copy the full SHA
    67c542f View commit details
    Browse the repository at this point in the history