Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main > release/client/2.3] test(client): Disable ODSP targeted signal tests #22741

Merged
merged 4 commits into from
Oct 10, 2024
Merged

[main > release/client/2.3] test(client): Disable ODSP targeted signal tests #22741

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6fc2544
disable tests for odsp
WillieHabi Oct 7, 2024
982b479
Revert "disable tests for odsp"
WillieHabi Oct 7, 2024
d3cd089
skip odsp
WillieHabi Oct 7, 2024
484d163
comments
WillieHabi Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion packages/test/test-end-to-end-tests/src/test/localTestSignals.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,8 +258,20 @@ describeCompat("Targeted Signals", "NoCompat", (getTestObjectProvider) => {
let clients: SignalClient[];
let provider: ITestObjectProvider;

beforeEach("setup containers", async () => {
beforeEach("setup containers", async function () {
provider = getTestObjectProvider();

/**
* Skip targeted signal test for ODSP driver as targeting signals for clients
* that share the same websocket connection is not yet supported.
* See {@link https://dev.azure.com/fluidframework/internal/_workitems/edit/18261}
*
* TODO: Re-enable tests once {@link https://dev.azure.com/fluidframework/internal/_workitems/edit/19030} is completed.
*/
if (provider.driver.type === "odsp") {
this.skip();
jason-ha marked this conversation as resolved.
Show resolved Hide resolved
}

clients = [];
for (let i = 0; i < numberOfClients; i++) {
const container = await (i === 0
Expand Down
Loading