[main > release/client/2.3] test(client): Disable ODSP targeted signal tests #22741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6fc2544. revert
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
the
area: tests
jason-ha
reviewed
Oct 7, 2024
jason-ha
changed the title
jason-ha
changed the title
jason-ha
approved these changes
Oct 7, 2024
|
@tylerbutler @rohandubal I'm looking for release approval here to disable some e2e targeted signal tests for odsp |
jason-ha
changed the title
|
Warning WARNING: This PR is targeting a release branch! All changes must first be merged into Changes to release branches require approval from the Patch Triage group before merging. For more details, see our internal documentation for the patch policy and processes for |
rohandubal
approved these changes
Oct 10, 2024
rohandubal
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ODSP targeted signal tests are consistently failing due to reuse of socket references in ODSP driver. These tests can be re-enabled once targetClientId is included in the return signal from PushChannel.
Cherry-pick of #22743