CRIMAP-427 Bump schemas gem (appeal_lodged_date) #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump the schemas gem, which contains the refactor of the appeal attributes, incorporating the new appeal_lodged_date. NOTE: even if Review wasn't using these appeal attributes before, once Apply start submitting new applications without the old `appeal_with_changes_maat_id` attribute, if Review remains in an old version of the schemas gem, the structs will not be able to map these new applications, as that attribute was marked as "mandatory presence" and no longer is returned by the datastore. This is the same issue we had recently with the `passportable` attribute.
To facilitate notifying and assigning PR reviews. Apply and Datastore had it already, Review was missing for some reason.
timpeat
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Bump the schemas gem, which contains the refactor of the appeal attributes, incorporating the new appeal_lodged_date.
NOTE: even if Review wasn't using these appeal attributes before, once Apply start submitting new applications without the old
appeal_with_changes_maat_idattribute, if Review remains in an old version of the schemas gem, the structs will not be able to map these new applications, as that attribute was marked as "mandatory presence" and no longer is returned by the datastore.This is the same issue we had recently with the
passportableattribute.Link to relevant ticket
https://dsdmoj.atlassian.net/browse/CRIMAP-427
Notes for reviewer
Review is not showing to the case worker these appeal attributes, I think there is a separate ticket to add those to the view.
How to manually test the feature
Everything should keep working with no additional changes other than this gem bump.