Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRIMAP-427 Bump schemas gem (appeal_lodged_date) #333

Merged
merged 2 commits into from
Jul 5, 2023
Merged

CRIMAP-427 Bump schemas gem (appeal_lodged_date) #333

merged 2 commits into from
Jul 5, 2023

Commits on Jul 5, 2023

  1. CRIMAP-427 Bump schemas gem (appeal_lodged_date) 

    Bump the schemas gem, which contains the refactor of the appeal attributes, incorporating the new appeal_lodged_date.

NOTE: even if Review wasn't using these appeal attributes before, once Apply start submitting new applications without the old `appeal_with_changes_maat_id` attribute, if Review remains in an old version of the schemas gem, the structs will not be able to map these new applications, as that attribute was marked as "mandatory presence" and no longer is returned by the datastore.

This is the same issue we had recently with the `passportable` attribute.
    @zheileman
    zheileman committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    bfc1008 View commit details
    Browse the repository at this point in the history

  2. Add CODEOWNERS file 

    To facilitate notifying and assigning PR reviews.

Apply and Datastore had it already, Review was missing for some reason.
    @zheileman
    zheileman committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    bfb2ddf View commit details
    Browse the repository at this point in the history