Avoid 10 minute goroutine leak in error case for handled errors #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jordan Liggitt <[email protected]>
|
FWIW; I'm also happy to add more maintainers from the k8s folks familiar with the code and how it's used in k8s if that helps; I think k8s is currently the only consumer of this module (leaving that to @dims and others to consider; just wanted to mention that I wouldn't have objections) |
aojea
reviewed
Jun 27, 2024
|
we are consuming it and it seems the plan we had to deprecate is going to take some time, we are interested in keeping it solid and only to fix bugs It should not be problematic, at least from my side, as it seems it has been running in production for lot of years |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #92 for handled errors
I think there's more we could do here to shorten the 10 minute hang for unhandled errors, but this is a smaller safer first improvement.
cc @aojea @seans3