Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid 10 minute goroutine leak in error case for handled errors #99

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Avoid 10 minute goroutine leak in error case for handled errors #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions connection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,16 +740,14 @@ func (s *Connection) shutdown(closeTimeout time.Duration) {

if err != nil {
duration := 10 * time.Minute
time.AfterFunc(duration, func() {
dims marked this conversation as resolved.
Show resolved Hide resolved
select {
case err, ok := <-s.shutdownChan:
if ok {
debugMessage("Unhandled close error after %s: %s", duration, err)
}
default:
}
})
s.shutdownChan <- err
timer := time.NewTimer(duration)
defer timer.Stop()
select {
case s.shutdownChan <- err:
// error was handled
case <-timer.C:
debugMessage("Unhandled close error after %s: %s", duration, err)
}
}
close(s.shutdownChan)
}
Expand Down
Loading