refactor: introduce Store(Item)?NotFoundException classes
#360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR detects when a `NOT_FOUND` gRPC error was specific to the storage client or not. For the storage client `NOT_FOUND`, there are two cases: the store was not found and the item was not found. To distinguish these two cases we use string matching on the grpcException message.
|
Not terribly important or urgent: we may consider organizing the various
|
|
Naming choices I made:
|
nand4011
previously approved these changes
Jun 20, 2024
We also document changes to make in the immediate future.
The metadata should come from the exception trailers, not the request metadata.
malandis
commented
Jun 20, 2024
Comment on lines
+54
to
+57
| if (errorCause == null) { | ||
| // TODO remove once control service is updated to send "err" in metadata | ||
| errorCause = grpcException.getMessage(); | ||
| } |
There was a problem hiding this comment.
Will update this once the server is up to date.
Comment on lines
+85
to
+92
| if (errorCause.contains("element_not_found")) { | ||
| return new StoreItemNotFoundException(grpcException, errorDetails); | ||
| // TODO change once control service is updated to send "Store with name" in metadata | ||
| } else if (errorCause.contains("Store with name")) { | ||
| return new StoreNotFoundException(grpcException, errorDetails); | ||
| } else { | ||
| return new NotFoundException(grpcException, errorDetails); | ||
| } |
There was a problem hiding this comment.
Will update these once the server is up to date.
nand4011
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR detects when a
NOT_FOUNDgRPC error was specific to thestorage client or not. For the storage client
NOT_FOUND, there aretwo cases: the store was not found and the item was not found.
To distinguish these two cases we use string matching on the
grpcException message.