Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: introduce Store(Item)?NotFoundException classes #360

Merged
merged 5 commits into from
Jun 20, 2024
Merged

refactor: introduce Store(Item)?NotFoundException classes #360

merged 5 commits into from
Jun 20, 2024

Commits on Jun 20, 2024

  1. refactor: introduce Store(Item)?NotFoundException classes 

    This PR detects when a `NOT_FOUND` gRPC error was specific to the
storage client or not. For the storage client `NOT_FOUND`, there are
two cases: the store was not found and the item was not found.

To distinguish these two cases we use string matching on the
grpcException message.
    @malandis
    malandis committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    1ff0e6f View commit details
    Browse the repository at this point in the history

  2. chore: style tweak

    @malandis
    malandis committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    f248916 View commit details
    Browse the repository at this point in the history

  3. refactor: already exists exception on create store

    @malandis
    malandis committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    5b26105 View commit details
    Browse the repository at this point in the history

  4. refactor: read error details from metadata 

    We also document changes to make in the immediate future.
    @malandis
    malandis committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    605a3e4 View commit details
    Browse the repository at this point in the history

  5. fix: remove metadata argument when calling exc mapper.convert 

    The metadata should come from the exception trailers, not the request
metadata.
    @malandis
    malandis committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    7b8fbf3 View commit details
    Browse the repository at this point in the history