Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: read from momento api key #382

Merged
merged 5 commits into from
Jul 9, 2024
Merged

ci: read from momento api key #382

merged 5 commits into from
Jul 9, 2024

Commits on Jul 9, 2024

  1. refactor: storage tests should use a single test store and base 

    Refactors the storage tests to use a base class similar to the one
just introduced for cache. Handles store set up and tear down uniformly.
    @malandis
    malandis committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    f98e96e View commit details
    Browse the repository at this point in the history

  2. fix: existing store test

    @malandis
    malandis committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    234da3b View commit details
    Browse the repository at this point in the history

  3. refactor: rename BaseTestClass to BaseCacheTestClass for clarity 

    Renames the cache `BaseTestClass` to `BaseCacheTestClass` for clarity.
    @malandis
    malandis committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    7fee081 View commit details
    Browse the repository at this point in the history

  4. ci: read credentials from MOMENTO_API_KEY 

    In order to be uniform with other SDKs, we read the API key from the
environment variable `MOMENTO_API_KEY`.
    @malandis
    malandis committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    763e74e View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into ci/read-from-momento-api-key

    @malandis
    malandis authored Jul 9, 2024
    Configuration menu
    Copy the full SHA
    ae1076e View commit details
    Browse the repository at this point in the history