Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: read from momento api key #382

Merged
merged 5 commits into from
Jul 9, 2024
Merged

Conversation

malandis
Copy link
Contributor

@malandis malandis commented Jul 9, 2024

In order to be uniform with other SDKs, we read the API key from the
environment variable MOMENTO_API_KEY.

Refactors the storage tests to use a base class similar to the one
just introduced for cache. Handles store set up and tear down uniformly.
Renames the cache `BaseTestClass` to `BaseCacheTestClass` for clarity.
In order to be uniform with other SDKs, we read the API key from the
environment variable `MOMENTO_API_KEY`.
@malandis malandis changed the base branch from main to refactor/rename-cache-test-base July 9, 2024 19:56
@malandis malandis requested review from nand4011, cprice404, rishtigupta and a team July 9, 2024 19:59
nand4011
nand4011 previously approved these changes Jul 9, 2024
Base automatically changed from refactor/rename-cache-test-base to main July 9, 2024 20:12
@malandis malandis dismissed nand4011’s stale review July 9, 2024 20:12

The base branch was changed.

@malandis malandis requested a review from nand4011 July 9, 2024 20:14
Copy link
Contributor

@cprice404 cprice404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@malandis malandis merged commit c8c9e57 into main Jul 9, 2024
5 checks passed
@malandis malandis deleted the ci/read-from-momento-api-key branch July 9, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants