feat: test and verify package on build #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruuuuuuuce
commented
Nov 15, 2023
bruuuuuuuce
commented
Nov 15, 2023
bruuuuuuuce
commented
Nov 15, 2023
bruuuuuuuce
commented
Nov 15, 2023
bruuuuuuuce
commented
Nov 15, 2023
bruuuuuuuce
commented
Nov 15, 2023
bruuuuuuuce
commented
Nov 15, 2023
bruuuuuuuce
commented
Nov 15, 2023
bruuuuuuuce
commented
Nov 15, 2023
bruuuuuuuce
commented
Nov 15, 2023
bruuuuuuuce
commented
Nov 15, 2023
eaddingtonwhite
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Nice work on this! Looks good should help us prevent merging any malformed packages! I think makes sense to just test this end to end vs try and verify package structure by hand. Hopefully will catch other future issues as well! I think it would be a good idea to add package/install verify step like this for other SDK's where makes sense as well. Maybe open some issues or add to notion page for CICD checks we have across SDK repos.
| npm i ../../../packages/client-sdk-nodejs/gomomento-sdk-0.0.1.tgz | ||
| rm -rf node_modules package-lock.json | ||
| npm i | ||
| npm run build |
There was a problem hiding this comment.
@bruuuuuuuce maybe think about in follow up pr or issue be good to maybe try running example or run some test also make sure can actually start up? At least making sure builds for now is better then nothing here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to #1045
Makes sure that nodejs and web sdk can be packaged and installed in our example repos, ensuring that the packing is correct