-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: test and verify package on build #1047
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
de56f6b
feat: test and verify package on build
bruuuuuuuce 4cb5cdf
Update .github/workflows/build.yml
bruuuuuuuce 6e69b1d
fix: also build common integration tests
bruuuuuuuce 2efdb9c
Update .github/workflows/build.yml
bruuuuuuuce 3ae82f0
Update .github/workflows/build.yml
bruuuuuuuce 42c683d
Apply suggestions from code review
bruuuuuuuce 2d46805
Apply suggestions from code review
bruuuuuuuce 01b6b40
Update build.yml
bruuuuuuuce 9435101
Update build.yml
bruuuuuuuce 5ae1dcc
chore: verify web sdk also packages correctly
bruuuuuuuce e780662
chore: should fail the package test
bruuuuuuuce 3ae185c
chore: revert last commit
bruuuuuuuce File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bruuuuuuuce maybe think about in follow up pr or issue be good to maybe try running example or run some test also make sure can actually start up? At least making sure builds for now is better then nothing here.