Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add account-sharing page #1138

Merged
merged 5 commits into from
Aug 19, 2024
Merged

feat: add account-sharing page #1138

merged 5 commits into from
Aug 19, 2024

Conversation

rishtigupta
Copy link
Contributor

@rishtigupta rishtigupta commented Aug 7, 2024

PR Description:

  • This commit adds another section to the main docs page for account-sharing feature:
Screenshot 2024-08-07 at 4 02 52 PM
  • Clicking on the "learn More" page takes you to a newly created account-sharing page (pull the pr locally to view the entire page):
Screenshot 2024-08-07 at 4 04 17 PM

Issue:

https://github.com/momentohq/momento-console/issues/853

@rishtigupta rishtigupta marked this pull request as ready for review August 7, 2024 23:05
@rishtigupta rishtigupta requested review from cprice404, a team and danielamiao August 7, 2024 23:05
@danielamiao
Copy link
Contributor

Thank you for the initial pass here! A few requested changes:

  1. Could you line up the account sharing section with the boxes above? Right now the account sharing box is wider than the boxes above it
  2. Change You are allowed to remove yourself from the account if you are not the account owner. to You cannot remove yourself from the account if you are the account owner.
  3. Under Switch Accounts section, add a first bullet: "If you are added to multiple accounts, you can switch between accounts inside the Momento Console."
  4. Under Member Limit section, add a note at the end: "You can also request a higher limit by emailing Momento at [email protected]"

@anitarua
Copy link
Collaborator

anitarua commented Aug 8, 2024

Looks great! Another suggestion if possible: add subheadings under "How to Use Account Sharing" that link to each of the 3 examples?
Screenshot 2024-08-08 at 4 09 10 PM

anitarua
anitarua previously approved these changes Aug 8, 2024
Copy link
Collaborator

@anitarua anitarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

- Click on the **Add Member** button.

<img src="/img/account-sharing/add-member.png" width="60%"/>
- Enter the email address of the user you wish to add. Please ensure that the user has an existing Momento account, meaning they must have signed into the Momento console at least once using that email address.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens if they type an e-mail address that has never logged in to the Momento console?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user will not be identified by the server and we throw an error on console saying "User could not be found."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay. i just tested it and I see what you mean. This PR is good then, but we should create a ticket for the console itself to augment that error message a bit, so that users will know what the remedy is if they get that error.

Copy link
Contributor

@cprice404 cprice404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one question and a few minor nits

cprice404
cprice404 previously approved these changes Aug 12, 2024
Copy link
Contributor

@cprice404 cprice404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but we should hold off on merging it until we release the console changes.

@rishtigupta rishtigupta merged commit 8d6b050 into main Aug 19, 2024
4 checks passed
@rishtigupta rishtigupta deleted the feat/account-sharing branch August 19, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants