PHPC-2180: Allow applications to register a log message subscriber #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
force-pushed
the
phpc-2180
branch
2 times, most recently
from
6af1920
to
f3fd721
Compare
alcaeus
reviewed
Sep 6, 2023
GromNaN
reviewed
Sep 11, 2023
jmikola
commented
Sep 12, 2023
jmikola
commented
Sep 12, 2023
jmikola
commented
Sep 12, 2023
jmikola
commented
Sep 13, 2023
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Sep 13, 2023
Temporarily depend on mongodb/mongo-php-driver#1395
jmikola
changed the title
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Sep 15, 2023
Temporarily depend on mongodb/mongo-php-driver#1395
alcaeus
reviewed
Sep 18, 2023
zend_call_method_if_exists() was introduced in PHP 8.2, so this ensures compatibility back to PHP 7.4. This could still be optimized to initialize FCI/FCC structs when a logger is first registered. If so, call_user_function can be replaced with zend_call_function().
These methods are never called, so type hints are unnecessary
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Sep 21, 2023
Temporarily depend on mongodb/mongo-php-driver#1395
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Sep 21, 2023
Temporarily depend on mongodb/mongo-php-driver#1395
alcaeus
approved these changes
Sep 21, 2023
GromNaN
approved these changes
Sep 21, 2023
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Sep 21, 2023
Temporarily depend on mongodb/mongo-php-driver#1395
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Sep 24, 2023
Temporarily depend on mongodb/mongo-php-driver#1395
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-2180
https://jira.mongodb.org/browse/PHPC-2289