Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPC-2180: Allow applications to register a log message subscriber #1395

Merged
merged 17 commits into from
Sep 21, 2023
Merged

PHPC-2180: Allow applications to register a log message subscriber #1395

merged 17 commits into from
Sep 21, 2023

Commits on Sep 20, 2023

  1. Support log handler class alongside mongodb.debug INI setting

    @jmikola
    jmikola committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    d5e3b90 View commit details
    Browse the repository at this point in the history

  2. Functions to log messages and convert log levels to strings

    @jmikola
    jmikola committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    2ea8497 View commit details
    Browse the repository at this point in the history

  3. levelToString tests

    @jmikola
    jmikola committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    d22604b View commit details
    Browse the repository at this point in the history

  4. Logger constant tests

    @jmikola
    jmikola committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    075a1b6 View commit details
    Browse the repository at this point in the history

  5. Preserve domain and message params and test addLogger

    @jmikola
    jmikola committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    ac56199 View commit details
    Browse the repository at this point in the history

  6. Use call_user_function instead of zend_call_method_if_exists 

    zend_call_method_if_exists() was introduced in PHP 8.2, so this ensures compatibility back to PHP 7.4.

This could still be optimized to initialize FCI/FCC structs when a logger is first registered. If so, call_user_function can be replaced with zend_call_function().
    @jmikola
    jmikola committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    aa16c1e View commit details
    Browse the repository at this point in the history

  7. Tests for addLogger and removeLogger

    @jmikola
    jmikola committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    8a5b159 View commit details
    Browse the repository at this point in the history

  8. Error tests for log() level and message params

    @jmikola
    jmikola committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    739dc33 View commit details
    Browse the repository at this point in the history

  9. Do not support MONGOC_LOG_LEVEL_TRACE in PHPC Logger API

    @jmikola
    jmikola committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    530f578 View commit details
    Browse the repository at this point in the history

  10. Simplify property and parameter name in add/removeLogger tests

    @jmikola
    jmikola committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    787e9e9 View commit details
    Browse the repository at this point in the history

  11. Add missing second call to addLogger() in NOP test

    @jmikola
    jmikola committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    2f66bcf View commit details
    Browse the repository at this point in the history

  12. Remove levelToString() function, which is not needed by PHPLIB

    @jmikola
    jmikola committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    e7a15f5 View commit details
    Browse the repository at this point in the history

  13. Rename Logger to LogSubscriber and integrate with Monitoring API

    @jmikola
    jmikola committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    8084ddb View commit details
    Browse the repository at this point in the history

  14. Use time() return value instead of time_t struct

    @jmikola
    jmikola committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    209d157 View commit details
    Browse the repository at this point in the history

  15. Simplify interface implementations with contravariance 

    These methods are never called, so type hints are unnecessary
    @jmikola
    jmikola committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    42608f3 View commit details
    Browse the repository at this point in the history

  16. Test removeSubscriber behavior with LogSubscriber&CommandSubscriber

    @jmikola
    jmikola committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    22f96fd View commit details
    Browse the repository at this point in the history

  17. PHPC-2289: Prohibit passing LogSubscriber to Manager::addSubscriber()

    @jmikola
    jmikola committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    0f421be View commit details
    Browse the repository at this point in the history