PHPC-2458: Deprecate float arg for UTCDateTime constructor #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
approved these changes
Sep 26, 2024
jmikola
force-pushed
the
1.x-phpc-2458
branch
from
728a4ac
to
038241e
Compare
Merged
alcaeus
added a commit
that referenced
this pull request
Oct 15, 2024
* v1.x: PHPC-2460: Use zend_zval_type_name instead of internal macros (#1714) PHPC-2464: Emit deprecation notice for negative "limit" Query option (#1710) PHPC-2458: Deprecate float arg for UTCDateTime constructor (#1695) Document how to run part of the test suite (#1690) Bump version to 1.21-dev (#1661) Update branch names for GHA workflows (#1646) PHPC-2343: Require PHP 8.1 (#1631)
alcaeus
added a commit
that referenced
this pull request
Oct 17, 2024
* v1.x: PHPC-2460: Use zend_zval_type_name instead of internal macros (#1714) PHPC-2464: Emit deprecation notice for negative "limit" Query option (#1710) PHPC-2458: Deprecate float arg for UTCDateTime constructor (#1695) Document how to run part of the test suite (#1690) Bump version to 1.21-dev (#1661) Update branch names for GHA workflows (#1646) PHPC-2343: Require PHP 8.1 (#1631)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-2458
I realized this was overlooked while going through documentation-needed tickets for 1.20. Floats, like strings, were only supported as an alternative for 32-bit platforms.
We can discuss whether this should slip into a 1.20.1 patch release (in which case I'll re-target v1.20) or be deferred to 1.21.0. Either way, I'm going to preemptively document this as deprecated along with strings.