This repository has been archived by the owner on Dec 9, 2019. It is now read-only.
Pagination and some other changes bunched up #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a DirbleURI named tuple that supports pagination. Also make URI parsing stricter and prepare it for pagination.
Also switches to using requests for constructing the URL to use in the cache, instead of re-inventing this wheel.
- Sort browse results as user countries, continents, categories rest. - Add next browse page directory. - Return next offset from pagination helper and client. - Set limit to 20 and max per page to 30, this way we get one request per browse on average. - Add offset to the dirble uri named tuple. - Fix missing handling of dirble:root uri.
Code wasn't handling case where first query returned to few requests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main fix is that we don't try and fetch "all", but instead try and support pagination via browse.
This also includes switching to https and some cosmetic changes to how browse results are grouped and sorted.