This repository has been archived by the owner on Dec 9, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Pagination and some other changes bunched up #19
Open
adamcik
wants to merge
21
commits into
master
Choose a base branch
from
pagination
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Feb 9, 2019
-
Update URI handling for Dirble.
Add a DirbleURI named tuple that supports pagination. Also make URI parsing stricter and prepare it for pagination.
Configuration menu - View commit details
-
Copy full SHA for ca4a399 - Browse repository at this point
Copy the full SHA ca4a399View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d24a46 - Browse repository at this point
Copy the full SHA 3d24a46View commit details -
Add method and params support to dirble client's fetch helper.
Also switches to using requests for constructing the URL to use in the cache, instead of re-inventing this wheel.
Configuration menu - View commit details
-
Copy full SHA for 7b16e2f - Browse repository at this point
Copy the full SHA 7b16e2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for aa08566 - Browse repository at this point
Copy the full SHA aa08566View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1523ab1 - Browse repository at this point
Copy the full SHA 1523ab1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77c819e - Browse repository at this point
Copy the full SHA 77c819eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 003b46b - Browse repository at this point
Copy the full SHA 003b46bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1090fb5 - Browse repository at this point
Copy the full SHA 1090fb5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84665d7 - Browse repository at this point
Copy the full SHA 84665d7View commit details -
Paginate browse + other changes...
- Sort browse results as user countries, continents, categories rest. - Add next browse page directory. - Return next offset from pagination helper and client. - Set limit to 20 and max per page to 30, this way we get one request per browse on average. - Add offset to the dirble uri named tuple. - Fix missing handling of dirble:root uri.
Configuration menu - View commit details
-
Copy full SHA for d4b00e5 - Browse repository at this point
Copy the full SHA d4b00e5View commit details
Commits on Feb 10, 2019
-
Code wasn't handling case where first query returned to few requests.
Configuration menu - View commit details
-
Copy full SHA for 074bdae - Browse repository at this point
Copy the full SHA 074bdaeView commit details -
Configuration menu - View commit details
-
Copy full SHA for bdebb27 - Browse repository at this point
Copy the full SHA bdebb27View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5161560 - Browse repository at this point
Copy the full SHA 5161560View commit details -
Configuration menu - View commit details
-
Copy full SHA for 777b709 - Browse repository at this point
Copy the full SHA 777b709View commit details -
Configuration menu - View commit details
-
Copy full SHA for ebd963d - Browse repository at this point
Copy the full SHA ebd963dView commit details
Commits on Feb 11, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 3228f35 - Browse repository at this point
Copy the full SHA 3228f35View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75cafd4 - Browse repository at this point
Copy the full SHA 75cafd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9671c4c - Browse repository at this point
Copy the full SHA 9671c4cView commit details
Commits on Feb 27, 2019
-
Configuration menu - View commit details
-
Copy full SHA for afe0fd3 - Browse repository at this point
Copy the full SHA afe0fd3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1dd04e4 - Browse repository at this point
Copy the full SHA 1dd04e4View commit details
Commits on Nov 18, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 6bf4481 - Browse repository at this point
Copy the full SHA 6bf4481View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.