Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPP-3577: Free onboarding and welcome email string additions #163

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Conversation

rafeerahman
Copy link
Contributor

Added the strings from the new free onboarding experience (mozilla/fx-private-relay#3961), and one for the welcome email.

Copy link
Contributor

@peiying2 peiying2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • All the new string IDs have an extra hyphen:
    profile-free-onboarding--welcome-headline. There should be a single hyphen between words in the string ID.
  • need to add a new entry to the .toml file because of onboarding.ftl.

profile-free-onboarding--next-step = Next
profile-free-onboarding--close-modal = Close modal
profile-free-onboarding--copy-mask-headline = Copy your mask to use it
profile-free-onboarding--copy-mask-description = Don’t worry about forgetting it—it will appear on your dashboard.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insert a space before and after

Copy link
Contributor

@flodolo flodolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The onboarding.ftl file already contains strings that we didn't want to translate. Has anything changed in this regard?

en/onboarding.ftl Outdated Show resolved Hide resolved
@rafeerahman
Copy link
Contributor Author

rafeerahman commented Nov 13, 2023

file already contains strings that we didn't want to translate

I am not entirely sure about this, @lloan do you know anything?

@lloan
Copy link
Contributor

lloan commented Nov 13, 2023

The onboarding.ftl file already contains strings that we didn't want to translate. Has anything changed in this regard?

Hi @flodolo - not sure if you were made aware, but the Relay UI team has essentially changed and now its only me and @rafeerahman. We are not sure as to what you mean with this comment. This new onboarding experience is for free users, an experience they did not have before and is separate from the premium user onboarding. There will be a future task to remove a component that is slightly related to onboarding (which will require us to remove strings). Can you elaborate?

@flodolo
Copy link
Contributor

flodolo commented Nov 13, 2023

Unlike @peiying2, I'm not involved in the project, I'm just making sure the PRs are technically sound.

onboarding.ftl was not listed in the TOML file on purpose, because it only contains strings for the premium experience available in US. This makes the strings available to all locales, which will be asked to localize them on top of the new free onboarding string.

To me, it sounds like these new strings should be in a separate file, not in the existing onboarding.ftl.

@lloan
Copy link
Contributor

lloan commented Nov 15, 2023

Moved strings to new file and updated .toml to include that new file.

Copy link
Contributor

@peiying2 peiying2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@peiying2 peiying2 merged commit 518f082 into main Nov 21, 2023
2 checks passed
@peiying2 peiying2 deleted the MPP-3577 branch November 21, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants