-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPP-3577: Free onboarding and welcome email string additions #163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- All the new string IDs have an extra hyphen:
profile-free-onboarding--welcome-headline
. There should be a single hyphen between words in the string ID. - need to add a new entry to the .toml file because of
onboarding.ftl
.
en/onboarding.ftl
Outdated
profile-free-onboarding--next-step = Next | ||
profile-free-onboarding--close-modal = Close modal | ||
profile-free-onboarding--copy-mask-headline = Copy your mask to use it | ||
profile-free-onboarding--copy-mask-description = Don’t worry about forgetting it—it will appear on your dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Insert a space before and after —
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The onboarding.ftl file already contains strings that we didn't want to translate. Has anything changed in this regard?
I am not entirely sure about this, @lloan do you know anything? |
Hi @flodolo - not sure if you were made aware, but the Relay UI team has essentially changed and now its only me and @rafeerahman. We are not sure as to what you mean with this comment. This new onboarding experience is for free users, an experience they did not have before and is separate from the premium user onboarding. There will be a future task to remove a component that is slightly related to onboarding (which will require us to remove strings). Can you elaborate? |
Unlike @peiying2, I'm not involved in the project, I'm just making sure the PRs are technically sound.
To me, it sounds like these new strings should be in a separate file, not in the existing |
Moved strings to new file and updated .toml to include that new file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Added the strings from the new free onboarding experience (mozilla/fx-private-relay#3961), and one for the welcome email.