Skip to content
This repository has been archived by the owner on Feb 7, 2019. It is now read-only.

Update first-run editor #292

Closed
5 tasks done
sandysage opened this issue Nov 6, 2017 · 11 comments
Closed
5 tasks done

Update first-run editor #292

sandysage opened this issue Nov 6, 2017 · 11 comments
Assignees
Milestone

Comments

@sandysage
Copy link
Contributor

sandysage commented Nov 6, 2017

When I first download the extension, I want to understand (or be reminded) of the purpose of Lockbox, in support of the first action: create the first entry.

NOTE This first entry is decoupled from creating an online account. It's a manual initial set-up, which is the end-result of the onboarding experience.

NOTE As explored in #209, securing a Lockbox is not a requirement for first run, in an attempt to allow users to get value prior to needing an account. This first run screen is the opportunity to explore what that value message needs to be to support creating a first entry.

Acceptance criteria

  1. It should have onboarding and support instructions to guide users through first time use
  2. It should provide easy-to-find access to additional information

Expected behavior

  1. Upon download, a user sees the "0 entry screen" or first run experience as outlined in the visual design (below).
  2. Creating a first entry is the primary call to action.
  3. After the first entry is created, the user is guided to secure the account with a Firefox account.
  4. There is persistent access to the "FAQ" via a navigation bar that links out to an external site with the FAQ details.

Visual design

screenshot-2017-12-6 lockbox fx add-on preview mode - invision

Context

In Alpha research, we discovered that the value and purpose of Lockbox needs to be more clearly communicated. This first run screen is where we can reinforce, and highlight, the message that prompted the Lockbox download.

Tasks

This relies upon FxA landing (#209) first.

@sandysage sandysage changed the title Update first-run landing screen Update first-run editor landing state Nov 6, 2017
@sandysage sandysage changed the title Update first-run editor landing state Update first-run editor Nov 6, 2017
@sandysage sandysage added the epic label Nov 6, 2017
@m8ttyB
Copy link
Contributor

m8ttyB commented Nov 7, 2017

Once additional context and design land for this, I'll add acceptance tests to the First Run Scenarios test suite.

@changecourse
Copy link
Contributor

@sandysage The latest visual designs represent the goals stated, but do we need to add additional tasks for both the removal of the master password?

I think the current flow accounts for our needs, but this issue (+/- any additional issues) may need to be updated to reflect all of the following changes:

  • Removal of need for master password creation
  • Rework of initial landing page to include primary navigation and sidebar
  • Upon successful installation of extension, an automatic launch of the lockbox tab (this may already function this way, but I'm not sure how to test that behavior on my end)

@devinreams
Copy link
Contributor

May need to be reconciled with #293 and then one closed?

@devinreams devinreams added backlog We have looked at and understand the issue. Prioritized with alignment to product initiatives. to do and removed backlog We have looked at and understand the issue. Prioritized with alignment to product initiatives. labels Nov 13, 2017
@sandysage sandysage added feature and removed epic labels Nov 14, 2017
@sandysage
Copy link
Contributor Author

Closing #293 as duplicate.

@devinreams
Copy link
Contributor

@sandysage @changecourse This is where we'd like to gather up all the changes to the landing page (homepage) and first run experience, right?

If so, based on our recent conversations, I think this is back to needs-ux until we're final-final on what you want to change, right?

@devinreams devinreams added this to the 1.0.0 - Pre milestone Nov 15, 2017
@devinreams devinreams added backlog We have looked at and understand the issue. Prioritized with alignment to product initiatives. and removed to do labels Nov 20, 2017
@devinreams devinreams removed this from the 1.0.0 - Pre milestone Nov 20, 2017
@sandysage sandysage assigned changecourse and unassigned sandysage Nov 28, 2017
@sandysage sandysage added to do and removed backlog We have looked at and understand the issue. Prioritized with alignment to product initiatives. labels Nov 28, 2017
@devinreams
Copy link
Contributor

devinreams commented Nov 28, 2017

Updates reflected in the original description include the fact this relies on #209 ("pre-run master password" swapped out for "FxA auth post-run")

As of today, this is what the design for the landing page looks like:

1_0_0_lockbox_home_-_welcome_screen

Here's the Invision for reference: https://mozilla.invisionapp.com/share/MHEBCD4PK#/screens/264173555

Worth highlighting (@linuxwolf) is the desire to have a "Sign In" to get set re-started. I feel this may not be feasible nor apply until we have sync in place?

@devinreams
Copy link
Contributor

@sandysage We've been (hopefully correctly) assuming the UI/UX implemented at #362 (FxA) and #331 (Photon styles) satisfies this "first-run" story.

Is that still accurate or should we split out anything else as a "todo"?

@devinreams devinreams mentioned this issue Dec 6, 2017
36 tasks
@devinreams devinreams added in progress We are actively working on it. and removed to do labels Dec 6, 2017
@sandysage
Copy link
Contributor Author

sandysage commented Dec 6, 2017

@devinreams I think the only thing I'm not seeing are the first-run instructions:
screenshot-2017-12-6 lockbox fx add-on preview mode - invision

Should that be captured in the Photon updates of #331 or opened as its own issue?

@devinreams
Copy link
Contributor

I think the only thing I'm not seeing are the first-run instructions:

Ah yes, we call that the empty state or 0-entries welcome page and have it called out in #331 as a "to do" still.

So, it sounds like we're indeed covered here with the work planned. 👍

@devinreams devinreams mentioned this issue Dec 7, 2017
18 tasks
@ghost ghost removed the in progress We are actively working on it. label Dec 8, 2017
@changecourse
Copy link
Contributor

changecourse commented Dec 8, 2017

Here are updated images @devinreams and @jimporter to remove + and the copy feedback...

promo 1

promo 2

promo 3

@changecourse
Copy link
Contributor

I figured we'd programmatically apply the border and shadow to these, as seen in Zeplin.

jimporter pushed a commit to jimporter/lockbox-extension that referenced this issue Dec 13, 2017
jimporter pushed a commit to jimporter/lockbox-extension that referenced this issue Dec 13, 2017
devinreams added a commit that referenced this issue Dec 13, 2017
* Remove link to empty API guide

Fixes #366
Depends on #51

* Remove redundant link

the COC is linked from the Contributing page which is a better landing page overall. keep it simple.

* Disable the filter when there are no items; resolves #324

* Add disabled state for buttons and disable the "add item" button when editing a new item

This also fixes some CSS with the "active" state of the button widget

* Refactor our telemetry to use Redux middleware

* Add missing telemetry events (and send the item id across)

* Create a Redux action for sending feedback

* Add a Redux action for copying fields

* Rename the object for various telemetry events

* Add telemetry to the doorhanger

* Be extra careful about the possibility of telemetry failing

* Firefox Accounts Integration (#362)

* Add instruction on how to run Tox recreate (#396)

* Add note on how to recreate tox dependencies

* Rewrap all the lines to 80

* Prepare 0.1.4-alpha and release notes (#393)

* Bump version to 0.1.4-alpha

* Quick draft and placeholder release notes

* Update release-notes.md

* Add "FxA can eat your logins" warnings

* Update release-notes.md

* typos

* Documentation updates from product team (#386)

* add FAQs placeholder page

* update homepage and styles to be HTML

because it was faster than trying to make custom theme stuff happen

* update navigation to be simpler

* change extension to match language

* finish converting index to html

* add draft FAQ copy

* typo and inconsistent use of Add-ons vs Extensions in menu

* back to markdown with admonitions

* fix styles to match new markup

* move the project note to the bottom of the page

* remove exclamation icons in headers

* updated tour and intro based on current FxA functionality

* copy edits from legal and content teams

* Disable the filter when there are no items; resolves #324

* Add disabled state for buttons and disable the "add item" button when editing a new item

This also fixes some CSS with the "active" state of the button widget

* Refactor our telemetry to use Redux middleware

* Add missing telemetry events (and send the item id across)

* Create a Redux action for sending feedback

* Add a Redux action for copying fields

* Rename the object for various telemetry events

* Add telemetry to the doorhanger

* Be extra careful about the possibility of telemetry failing

* Firefox Accounts Integration (#362)

* add the tour screen shots

* address @mheubusch comments as best can be done

* Incorporate more Photon-inspired UX and UI improvements (#351)

* Fix text color of wrapped inputs; resolves #264

* Change background color of primary content area when viewing or creating an entry

And change color of selected item in scroll list to match so it looks like one continuous tab/element

* Removal of horizontal divider in Create a New Entry & View Entry Details

and change Delete button to be a button

* Add arrow indicator, hide when item selected

* Match title and subtitle font sizes and weights

* Adjust sidebar width

* Remove item count from toolbar

* Update Navigation to match comps

- navigation links to match Photon
- larger with puffy sizes
- no side vs main toolbar

* fix font-weight typos from bad partial commit

* Add link theme and external link icon

* Small copy changes recently noticed

* Center text on modal

* Remove sidebar border

Need a clever way to add it back and "punch through" selected items, though

* Normal button for home

* re-order origin and title fields so address is first

* remove notes placeholder

* better spacing for empty sidebar text

* sidebar item typography and colors to match

* make the indicator arrow more style than semantic

and use the proper icon

* add semantic navigation arrow image to replace left arrow tag

* rename new, edit, delete, button and confirmation strings

* hide right border on selected list item so its like a tab into the panel

* improved modal styles

* consistent bytton styles and sizes

* improved item detail input and title styles

* remove fancy counter from homepage

* quick tweaks to doorhanger styles

* re-order title and address to match d6ea846

* actually finish the re-ordering of title and address

from 0c0884a

* updated description to match comps

* update sidebar background colors to match comps

* merge FxA changes into homepage

* remove pre-Alpha homepage greeting

* lower-case 'e' for entry now

* use product-title placeholder and undo accidental CSS specificity breakage

* remove superfulous brackets

* remove superfulous height and border, set proper color on item details

* remove unused localized toolbar string

* Merge and fix some conflicts against FxA

* remove unused Homepage prop

removed at 536d7e4

* sane sidebar min with grid shift to achieve wider-ness

* move homepage and FxA blurb styles around and match comps

* improve text and button hierarchy and clarity on modal dialogs

* localize the backwards navigation arrow on popup

* update item and scroll list colors to match Photon greys

* "provide feedback" link for user clarity

submit feedback happens after feedback is drafted

* explicitly disable browser style, prevents warning messages

* quick attempt fix vertical alignment of arrow indicator

* fix integration tests for login, add entry, delete, and doorhanger

* set a normal min-width to achieve fairly consistent size buttons

so short words like "Save" and "Edit" fill a minimum amount of space that has a good hit-area, but "Delete Entry" expands to fill space

* change the "go back" button to micro to fit the space better

* update ID locator in login.py tests

* add external link widget (#397)

* add external link widget

* address code review comments

* address children property feedback

* integration test: find the correct sign in link

* put things back where they were and address @jimporter review comments

* Updated integration tests

* Fix failing integration tests.

* Fix flake8

* Fix text color of wrapped inputs; resolves #264

* Change background color of primary content area when viewing or creating an entry

And change color of selected item in scroll list to match so it looks like one continuous tab/element

* Removal of horizontal divider in Create a New Entry & View Entry Details

and change Delete button to be a button

* Add arrow indicator, hide when item selected

* Match title and subtitle font sizes and weights

* Adjust sidebar width

* Remove item count from toolbar

* Update Navigation to match comps

- navigation links to match Photon
- larger with puffy sizes
- no side vs main toolbar

* fix font-weight typos from bad partial commit

* Add link theme and external link icon

* Small copy changes recently noticed

* Center text on modal

* Remove sidebar border

Need a clever way to add it back and "punch through" selected items, though

* Normal button for home

* re-order origin and title fields so address is first

* remove notes placeholder

* better spacing for empty sidebar text

* sidebar item typography and colors to match

* make the indicator arrow more style than semantic

and use the proper icon

* add semantic navigation arrow image to replace left arrow tag

* rename new, edit, delete, button and confirmation strings

* hide right border on selected list item so its like a tab into the panel

* improved modal styles

* consistent bytton styles and sizes

* improved item detail input and title styles

* remove fancy counter from homepage

* quick tweaks to doorhanger styles

* re-order title and address to match d6ea846

* updated description to match comps

* actually finish the re-ordering of title and address

from 0c0884a

* update sidebar background colors to match comps

* merge FxA changes into homepage

* remove pre-Alpha homepage greeting

* lower-case 'e' for entry now

* use product-title placeholder and undo accidental CSS specificity breakage

* remove superfulous brackets

* remove superfulous height and border, set proper color on item details

* remove unused localized toolbar string

* Merge and fix some conflicts against FxA

* remove unused Homepage prop

removed at 536d7e4

* sane sidebar min with grid shift to achieve wider-ness

* move homepage and FxA blurb styles around and match comps

* improve text and button hierarchy and clarity on modal dialogs

* localize the backwards navigation arrow on popup

* update item and scroll list colors to match Photon greys

* "provide feedback" link for user clarity

submit feedback happens after feedback is drafted

* explicitly disable browser style, prevents warning messages

* quick attempt fix vertical alignment of arrow indicator

* fix integration tests for login, add entry, delete, and doorhanger

* set a normal min-width to achieve fairly consistent size buttons

so short words like "Save" and "Edit" fill a minimum amount of space that has a good hit-area, but "Delete Entry" expands to fill space

* change the "go back" button to micro to fit the space better

* update ID locator in login.py tests

* add external link widget (#397)

* add external link widget

* address code review comments

* address children property feedback

* integration test: find the correct sign in link

* put things back where they were and address @jimporter review comments

* Updated integration tests

* Fix failing integration tests.

* Fix flake8

* Fix homepage wait to load

* Fix flake8

* Fix homepage wait to load

* slow the browser down because these tests are failing very occasionally

* make sure the FxA linked typography matches signed out guest mode

* bump toolbar and first run actions link sizes up to match nearby button sizes

* localization introduced at 9db70b2 is not actually working this way

returning [object Object] instead of string

* put back input sizes so there's no visibile jump going from edit to view

undo some of my changes at 234d001 so things line up properly

* better wrapping accounting for width of "Lockbox"

* also set account-summary span to 15px for now for nav size consistency

* sentence case our tagline

* minr Padd missing semi-colon

* address input review comments

* Localize the back button for <PanelHeader/>

* Use normal button style for signing into Firefox Account

* Simplify button CSS when using button icons

This does a few things:
* Makes the <PanelHeader/>'s back button bigger so people have an easier time
  clicking it
* Sets line-height of buttons to 1 to ensure that icons are vertically
  centered (this is ok because the labels never wrap anyway)
* Adjusts the vertical alignment of icons when there's a label next to them

For text-only buttons, there should be no visual changes whatsoever.

* Use a "ghost" button with some custom styling for the "copy" button

* Remove "link" button theme

* Add missing semicolon

* Move `grid-column-start` definition for the main toolbar to the proper place

* Move font-size definition for the main toolbar to a better spot

* Fix tests

* Updated waits for integration tests.

* Fix integration test flake8 errors.

* Input focus state should be higher priority than input hover state!

* Improve styles for management page's <ItemFilter/>

* fix from @jrbenny35

* Make the origin field non-monospace

* add HEADLESS back

* Add an external FAQ link to navigation (#387)

* Replicate send-feedback to create a FAQ link component

admittedly a total copy/paste job and not certain if good for long term maintenance with potential for changes (like if/when one or the other becomes something else) versus making send-feedback abstract to take two and then split out later when either one changes to be something other than a simple link :thinking_face:

* redo open-faq to match send-feedback with telemetry updates

* update to use common ExternalLink widget

* Fix sizing of various components in the manager to allow (very!) narrow screens

* Add an intro page to the manager; resolves #292

* Remove ENABLE_DOORHANGER code

we won't ever want to have it not enabled from here forward, so removing the code entirely

* Minor fixes before release (#407)

* fix broken markdown link

* change "FAQs" to "FAQ" based on recent copy text decision

* change intro titles to sentence case based on recent copy text decision

* remove first run warning about no data guarantee

we want users to rely on this now

* visually center the FxA blurbs on the home page

* increase FAQ navigation link size to match toolbar sizes

* add a little more space between clickable navigation items in toolbar

* Extended timeout for integration tests.

* Re-wrap the input item fields so they don't regress and break the page (#409)

* wrap the notes text area input so it doesn't break the page

* remove redundant overflow styles
kimberlythegeek pushed a commit to kimberlythegeek/lockbox-extension that referenced this issue Jan 5, 2018
devinreams added a commit that referenced this issue Mar 8, 2018
* Remove link to empty API guide

Fixes #366
Depends on #51

* Remove redundant link

the COC is linked from the Contributing page which is a better landing page overall. keep it simple.

* Disable the filter when there are no items; resolves #324

* Add disabled state for buttons and disable the "add item" button when editing a new item

This also fixes some CSS with the "active" state of the button widget

* Refactor our telemetry to use Redux middleware

* Add missing telemetry events (and send the item id across)

* Create a Redux action for sending feedback

* Add a Redux action for copying fields

* Rename the object for various telemetry events

* Add telemetry to the doorhanger

* Be extra careful about the possibility of telemetry failing

* Firefox Accounts Integration (#362)

* Add instruction on how to run Tox recreate (#396)

* Add note on how to recreate tox dependencies

* Rewrap all the lines to 80

* Prepare 0.1.4-alpha and release notes (#393)

* Bump version to 0.1.4-alpha

* Quick draft and placeholder release notes

* Update release-notes.md

* Add "FxA can eat your logins" warnings

* Update release-notes.md

* typos

* Documentation updates from product team (#386)

* add FAQs placeholder page

* update homepage and styles to be HTML

because it was faster than trying to make custom theme stuff happen

* update navigation to be simpler

* change extension to match language

* finish converting index to html

* add draft FAQ copy

* typo and inconsistent use of Add-ons vs Extensions in menu

* back to markdown with admonitions

* fix styles to match new markup

* move the project note to the bottom of the page

* remove exclamation icons in headers

* updated tour and intro based on current FxA functionality

* copy edits from legal and content teams

* Disable the filter when there are no items; resolves #324

* Add disabled state for buttons and disable the "add item" button when editing a new item

This also fixes some CSS with the "active" state of the button widget

* Refactor our telemetry to use Redux middleware

* Add missing telemetry events (and send the item id across)

* Create a Redux action for sending feedback

* Add a Redux action for copying fields

* Rename the object for various telemetry events

* Add telemetry to the doorhanger

* Be extra careful about the possibility of telemetry failing

* Firefox Accounts Integration (#362)

* add the tour screen shots

* address @mheubusch comments as best can be done

* Incorporate more Photon-inspired UX and UI improvements (#351)

* Fix text color of wrapped inputs; resolves #264

* Change background color of primary content area when viewing or creating an entry

And change color of selected item in scroll list to match so it looks like one continuous tab/element

* Removal of horizontal divider in Create a New Entry & View Entry Details

and change Delete button to be a button

* Add arrow indicator, hide when item selected

* Match title and subtitle font sizes and weights

* Adjust sidebar width

* Remove item count from toolbar

* Update Navigation to match comps

- navigation links to match Photon
- larger with puffy sizes
- no side vs main toolbar

* fix font-weight typos from bad partial commit

* Add link theme and external link icon

* Small copy changes recently noticed

* Center text on modal

* Remove sidebar border

Need a clever way to add it back and "punch through" selected items, though

* Normal button for home

* re-order origin and title fields so address is first

* remove notes placeholder

* better spacing for empty sidebar text

* sidebar item typography and colors to match

* make the indicator arrow more style than semantic

and use the proper icon

* add semantic navigation arrow image to replace left arrow tag

* rename new, edit, delete, button and confirmation strings

* hide right border on selected list item so its like a tab into the panel

* improved modal styles

* consistent bytton styles and sizes

* improved item detail input and title styles

* remove fancy counter from homepage

* quick tweaks to doorhanger styles

* re-order title and address to match d6ea846

* actually finish the re-ordering of title and address

from 0c0884a

* updated description to match comps

* update sidebar background colors to match comps

* merge FxA changes into homepage

* remove pre-Alpha homepage greeting

* lower-case 'e' for entry now

* use product-title placeholder and undo accidental CSS specificity breakage

* remove superfulous brackets

* remove superfulous height and border, set proper color on item details

* remove unused localized toolbar string

* Merge and fix some conflicts against FxA

* remove unused Homepage prop

removed at 536d7e4

* sane sidebar min with grid shift to achieve wider-ness

* move homepage and FxA blurb styles around and match comps

* improve text and button hierarchy and clarity on modal dialogs

* localize the backwards navigation arrow on popup

* update item and scroll list colors to match Photon greys

* "provide feedback" link for user clarity

submit feedback happens after feedback is drafted

* explicitly disable browser style, prevents warning messages

* quick attempt fix vertical alignment of arrow indicator

* fix integration tests for login, add entry, delete, and doorhanger

* set a normal min-width to achieve fairly consistent size buttons

so short words like "Save" and "Edit" fill a minimum amount of space that has a good hit-area, but "Delete Entry" expands to fill space

* change the "go back" button to micro to fit the space better

* update ID locator in login.py tests

* add external link widget (#397)

* add external link widget

* address code review comments

* address children property feedback

* integration test: find the correct sign in link

* put things back where they were and address @jimporter review comments

* Updated integration tests

* Fix failing integration tests.

* Fix flake8

* Fix text color of wrapped inputs; resolves #264

* Change background color of primary content area when viewing or creating an entry

And change color of selected item in scroll list to match so it looks like one continuous tab/element

* Removal of horizontal divider in Create a New Entry & View Entry Details

and change Delete button to be a button

* Add arrow indicator, hide when item selected

* Match title and subtitle font sizes and weights

* Adjust sidebar width

* Remove item count from toolbar

* Update Navigation to match comps

- navigation links to match Photon
- larger with puffy sizes
- no side vs main toolbar

* fix font-weight typos from bad partial commit

* Add link theme and external link icon

* Small copy changes recently noticed

* Center text on modal

* Remove sidebar border

Need a clever way to add it back and "punch through" selected items, though

* Normal button for home

* re-order origin and title fields so address is first

* remove notes placeholder

* better spacing for empty sidebar text

* sidebar item typography and colors to match

* make the indicator arrow more style than semantic

and use the proper icon

* add semantic navigation arrow image to replace left arrow tag

* rename new, edit, delete, button and confirmation strings

* hide right border on selected list item so its like a tab into the panel

* improved modal styles

* consistent bytton styles and sizes

* improved item detail input and title styles

* remove fancy counter from homepage

* quick tweaks to doorhanger styles

* re-order title and address to match d6ea846

* updated description to match comps

* actually finish the re-ordering of title and address

from 0c0884a

* update sidebar background colors to match comps

* merge FxA changes into homepage

* remove pre-Alpha homepage greeting

* lower-case 'e' for entry now

* use product-title placeholder and undo accidental CSS specificity breakage

* remove superfulous brackets

* remove superfulous height and border, set proper color on item details

* remove unused localized toolbar string

* Merge and fix some conflicts against FxA

* remove unused Homepage prop

removed at 536d7e4

* sane sidebar min with grid shift to achieve wider-ness

* move homepage and FxA blurb styles around and match comps

* improve text and button hierarchy and clarity on modal dialogs

* localize the backwards navigation arrow on popup

* update item and scroll list colors to match Photon greys

* "provide feedback" link for user clarity

submit feedback happens after feedback is drafted

* explicitly disable browser style, prevents warning messages

* quick attempt fix vertical alignment of arrow indicator

* fix integration tests for login, add entry, delete, and doorhanger

* set a normal min-width to achieve fairly consistent size buttons

so short words like "Save" and "Edit" fill a minimum amount of space that has a good hit-area, but "Delete Entry" expands to fill space

* change the "go back" button to micro to fit the space better

* update ID locator in login.py tests

* add external link widget (#397)

* add external link widget

* address code review comments

* address children property feedback

* integration test: find the correct sign in link

* put things back where they were and address @jimporter review comments

* Updated integration tests

* Fix failing integration tests.

* Fix flake8

* Fix homepage wait to load

* Fix flake8

* Fix homepage wait to load

* slow the browser down because these tests are failing very occasionally

* make sure the FxA linked typography matches signed out guest mode

* bump toolbar and first run actions link sizes up to match nearby button sizes

* localization introduced at 9db70b2 is not actually working this way

returning [object Object] instead of string

* put back input sizes so there's no visibile jump going from edit to view

undo some of my changes at 234d001 so things line up properly

* better wrapping accounting for width of "Lockbox"

* also set account-summary span to 15px for now for nav size consistency

* sentence case our tagline

* minr Padd missing semi-colon

* address input review comments

* Localize the back button for <PanelHeader/>

* Use normal button style for signing into Firefox Account

* Simplify button CSS when using button icons

This does a few things:
* Makes the <PanelHeader/>'s back button bigger so people have an easier time
  clicking it
* Sets line-height of buttons to 1 to ensure that icons are vertically
  centered (this is ok because the labels never wrap anyway)
* Adjusts the vertical alignment of icons when there's a label next to them

For text-only buttons, there should be no visual changes whatsoever.

* Use a "ghost" button with some custom styling for the "copy" button

* Remove "link" button theme

* Add missing semicolon

* Move `grid-column-start` definition for the main toolbar to the proper place

* Move font-size definition for the main toolbar to a better spot

* Fix tests

* Updated waits for integration tests.

* Fix integration test flake8 errors.

* Input focus state should be higher priority than input hover state!

* Improve styles for management page's <ItemFilter/>

* fix from @jrbenny35

* Make the origin field non-monospace

* add HEADLESS back

* Add an external FAQ link to navigation (#387)

* Replicate send-feedback to create a FAQ link component

admittedly a total copy/paste job and not certain if good for long term maintenance with potential for changes (like if/when one or the other becomes something else) versus making send-feedback abstract to take two and then split out later when either one changes to be something other than a simple link :thinking_face:

* redo open-faq to match send-feedback with telemetry updates

* update to use common ExternalLink widget

* Fix sizing of various components in the manager to allow (very!) narrow screens

* Add an intro page to the manager; resolves #292

* Remove ENABLE_DOORHANGER code

we won't ever want to have it not enabled from here forward, so removing the code entirely

* Minor fixes before release (#407)

* fix broken markdown link

* change "FAQs" to "FAQ" based on recent copy text decision

* change intro titles to sentence case based on recent copy text decision

* remove first run warning about no data guarantee

we want users to rely on this now

* visually center the FxA blurbs on the home page

* increase FAQ navigation link size to match toolbar sizes

* add a little more space between clickable navigation items in toolbar

* Extended timeout for integration tests.

* Re-wrap the input item fields so they don't regress and break the page (#409)

* wrap the notes text area input so it doesn't break the page

* remove redundant overflow styles

* Fix feedback link on docs/index (#411)

Signed-off-by: Peter deHaan <[email protected]>

* Added error handling to class name munger.

* Allow running integration tests on Python 3.* instead of just 3.6

* Release instructions on creating a production PR (#422)

* update instructions to reflect creation of a PR from master to production

* set correct release date, remove unnecessary heading

* more clear about how to compare master and production branches

with handy link that should always work!

* request explicit approval in the instructions

* add handy link to releases

* address nits

* Update contributing URL to point to waffle, not GitHub projects (#423)

* Move unit tests to test/unit/; resolves #383

* Update pytest from 3.3.0 to 3.3.1

* Update pytest-selenium from 1.11.0 to 1.11.3

* Update pytest-xdist from 1.18.2 to 1.20.1

* Convert to Date.now() to avoid NaN

* Fix invalid docs/css/extra.css rule (#434)

* explicitly use guest-mode app key (#436)

* add integration test script runner (#400)

* Don't fire an onChange event from <ScrollingList/> if the new item is already selected

This resolves - in a roundabout way - an issue with clicking the "new item"
placeholder entry in the item list causing the editor widget to go away.

* Improve selected/focus state for the item list; resolves #414

* Add stylelintrc config

* Run CSS through prettier

* Add a warn-only mode for stylelint

* Make Everything Build Again (#470)

* Add stylelintrc config

* Run CSS through prettier

* Add a warn-only mode for stylelint

* make everything build again

* Pulls version from package.json and appends to survey link

* Update dependencies (2018-01) (#472)

* Fix for failing builds on travisci (#474)

* Ensure that updating the fields in <EditItemDetails/> actually triggers a UI change

This helps bullet-proof our code for issues like #438, though the next commit
will resolve this in a different way (by disabling the new button during
editing).

* Disable the "new item" button when editing an existing item; resolves #438

* initial test plan for our telemetry work

* Fix <ScrollingList/> prop types; resolves #451

* Update dependencies to enable Greenkeeper 🌴 (#304)

* Update Release Notes and Version to 0.5.1 (#501)

* Implement a better copy-to-clipboard button; resolves #318

* Fix spurious warning from <ItemDetailsPanel/> test

* Add timeout test for <CopyToClipboardButton/>

* Remove unused <ErrorMessage/>; resolves #240

* chore(package): update style-loader to version 0.20.1

Closes #502

* Display More Profile Information (#486)

* Implement light vs. full signout (#506)

* Add a <Link/> widget and ensure that it (and <ExternalLink/>) are keyboard-accessible

* Implement a dropdown for the account label; resolves #442

* Update button's focus CSS to match spec

* Change <Link/>'s implementation to use a button

This ensure that we don't see a spurious URL in the bottom of the window
(generated by Firefox) in the bottom of the window.

* Fix scrolling in management view (#531)

* update to version 0.1.6-alpha (#527)

* Update eslint-plugin-mozilla to the latest version 🚀 (#509)

* chore(package): update events to version 2.0.0 (#511)

* chore(package): update babel-minify-webpack-plugin to version 0.3.0 (#525)

* chore(package): update eslint-plugin-node to version 6.0.0 (#518)

* Fix: guest mode does not work on restart (#543)

* pin and ignore to [email protected] (#546)

* Refresh OAuth Access Tokens (#547)

* Styling adjustments for the account dropdown. (#549)

* Update Version and Release Notes to 0.1.7-alpha (#558)

* chore(package): update eslint-plugin-no-unsanitized to version 3.0.0 (#537)

* chore(package): update mocha to version 5.0.1 (#544)

* chore(package): update stylelint to version 9.1.1 (#566)

* chore(package): update stylelint-config-recommended to version 2.1.0 (#551)

* Add Support For Telemetry Scalars; Update Metrics.md (#552)

* Provide documentation about how to post PRs (#507)

* Ensure FxA account is stored always (#570)

* Update Version and Release Notes to 0.1.7-alpha1 (#571)

* Updated text color of entry list empty state for better contrast (#560)

* Add config file for pyup.io to update weekly (#586)

* create pyup.io config file

* update all dependencies, not just security

* remove extra whitespace

* Update flake8-isort from 2.2.2 to 2.4 (#587)

* Update pytest from 3.3.1 to 3.4.1 (#589)

* Update pytest-selenium from 1.11.3 to 1.11.4 (#590)

* Update pypom from 1.2.0 to 1.3.0 (#594)

* Update selenium from 3.8.0 to 3.9.0 (#592)

* Update pytest-xdist from 1.20.1 to 1.22.2 (#591)

* Update flake8-docstrings from 1.1.0 to 1.3.0 (#588)

* More account dropdown style updates (#597)

* Styling updates based off Jim's code review of #549

-Updated pseudo-elements to have two colons instead of one
-Moved toolbar margin update to be specific to navigation bar
-Removed arrowhead down icon that is no longer in use
-Updated dropdown hover, focus and active states after reviewing how Firefox browser handles similar items

* Updating toolbar to use px instead of ch to be consistent.

* Include whitespace in item fields so new lines are output (#596)

* Include whitespace in item fields so new lines are output

* move white-space to all input text fields

* Automatically focus the filter input when the page loads; resolves #573

* Styling updates around entry list items (#553)

* Styling updates around entry list items

-Active and focus states
-Increased padding to match mocks
-New chevron icon
-Updated aside background color
-Moved border between search and entries in order to apply active border color to top entry item
-Small copy change to empty state

* Changes based off PR feedback

-Removed arrowhead right icon that is no longer used
-Removed some styling around border between filter and list items until we get the filter updated.

* Add custom "no username" instruction text when adding entry

* Remove string interpolation and use better const name

* Ran cheveron-right through svgo, sizing was also updated.

* update to latest package-lock.json after production branch merge

to get the two branches up to date and matching each other

they diverged and production became 95 commits behind and 5 ahead due to rename/delete conflicts and I "took" the conflicting changes from production to the package-lock file, now I want the actual latest result of `npm i`

* Updating styling of 0 entries (home) page to reflect intended typography and spacing (#607)

- Into image shadow to Shadow 10
- Updated image border
- Defined line height for intro paragraphs

* Create a <PanelFooterButton/> and update the styles for the unlock do… (#601)

* Create a <PanelFooterButton/> and update the styles for the unlock doorhanger; resolves #482

* latest Nessie with darker waves

* Update selenium from 3.9.0 to 3.10.0

* chore(package): update documentation to version 6.0.0

* Require python 3.6 in deploy stage so pip can install tornado

* Create/Edit Entry Details Styling Adjustments (#567)

* Styling adjustments for entry details

-Added show/hide icons for password
-Reordered fields to match new designs
-Removed monospace class from username field
-Fixed sizing/spacing to match designs
-Updated to use box-sizing: border box, and fixed issues this caused in other areas
-Updated placeholder copy and labels to match design changes
-Added min-width to buttons

* Adding min-width to normal button style and larger min-width for primary buttons

* Styling for dialog box and adding new critical/red button style

* Changes based on PR review

-ran svgo on show icon to optimize
-created new notes class in entry details for styling
-removed box sizing and associated style changes
-moved password styles to input.css
-Removed show/hide button text and keys
-Changed critical theme to danger theme
-Reverted dialog to use primary button by default

* Re-localize the show/hide password input buttons

* Fix input tests to also check for first "input" class

* Better RegEx for munged password input class tests

* Fixing missed styles from box-sizing removal that needed updated

* Provide the option of using "danger" buttons in dialog boxes

These are currently used in two places:
* Deleting items
* Resetting the datastore

* restore indentation

* Fixes based on PR changes requested

-Ran show icon through svgo
-Moved input max-width for entry creation/edition fields to item-fields.css
-Created new "wide" button sub-theme for instances to include min-width property
-Added size theme to save/edit button on entry details

* Adding .input class to item fields for styling and removing unnecessary selector

* Improvements to search bar styling in full manage mode (#562)

* Styling adjustments for entry list filter.

-Added search icon
-Updated padding/colors
-Included clear icon but needs implemented
-Removed "entries" from placeholder copy

* Styling updates for entries list filter in aside

-Fixed padding/sizing to match design
-Added search icon
-Replaced text link with 'clear icon'
-Updated placeholder copy to 'search lockbox'

* Changes after review with Ryan

-Darkening placeholder text
-Updated border radius on inputs
-Reverting search to use regular weight

* Moving location of styles for filter/search in order to cover both doorhanger and full page view

* Adding MPL-2.0 license to item-filter file and new line on app.css

* Updates based on PR feedback

-Added new line at end of SVG files
-Removed item-filter.css and moved styles to input.css file
-Wrapped filter in <toolbar> element and applied padding there
-Added title attribute to clear button

* Removing "clear" text from filter button

* Update input test regex to include first input filter class

* Restore localization of "Clear" text on search

* Better RegEx for munged input class tests

* Removed some unnecessary styles left behind and updated padding for consistency.

* Ran clear and search svgs through svgo

* Restore filter styles lost in master branch merge 28e31d5

* Make sure options_ui is fully displayed on about:addons (#603)

* Make sure options_ui is fully displayed on about:addons

* flex-direction is actually not necessary, not sure why i ended up with it

* add margin so button focus state fits and text aligns with items above

* add min-height to give the warning dialog more room to breathe

* added accessibility test plan to docs

* Attempt to speed up branch and PR builds with Travis CI caching (#604)

* Speed up branch and PR builds with Travis CI caching
* add pip cache

* Styling adjustment to align entry detail buttons during edit and view mode change (#608)

* Fix <ItemFilter/> to actually update its state from Redux

* Fix importing of chai-enzyme in <ButtonStack/> test

* Automatically select the filter input's text on load (if there is any)

* Pre-fill the URL of the current tab into the doorhanger's filter

* Prepare 0.1.8 release (#612)

* bump version numbers to 0.1.8-alpha

* draft release notes based on current progress

and fixed release note headings in previous release

* recent additions for release notes

* last items included in this release

* remove depdencies updates from release notes
@devinreams devinreams added the P1 label Mar 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants