Update UX strings #163
Update UX strings #163
Conversation
devinreams
force-pushed
the
update-ux-strings
branch
from
9ad2b76
to
6534234
Compare
|
@changecourse @sandysage Let's look at getting final strings in for Alpha. You'll see each file has some that we can swap out with little-to-no-work. I took a first pass based on what's in Invision... (click "Files Changed" here to see) |
ghost
added
the
linuxwolf
force-pushed
the
update-ux-strings
branch
from
e2e7c44
to
acc20a1
Compare
There was a problem hiding this comment.
not all instances of item are being captured, nor is the changes for "Entry Name" and "Website Address"
as seen here: https://mozilla.invisionapp.com/share/P6DT2HP8X#/256782988_1-0-3_Lockbox_Home_-_Entry_Detail_-_Add_Entry_-_Filled
|
|
||
| homepage-no-passwords = | ||
| Welcome to Lockbox! I'm Lockie, and I'm here to help you lock | ||
| up your passwords! | ||
|
|
There was a problem hiding this comment.
I'm pretty sure this will break things. The trailing whitespace is important for ensuring that fluent.js parses the entire body as one string.
There was a problem hiding this comment.
Atom was overly helpful. Added back in next commit.
| toolbar-go-home = Home | ||
| toolbar-send-feedback = Feedback | ||
|
|
||
| item-filter.placeholder = Filter… | ||
| item-filter.placeholder = Search for an Entry |
There was a problem hiding this comment.
I believe the prevailing style in Firefox is sentence case, not title case.
| [one] 1 item | ||
| *[other] { $count } items | ||
| [one] 1 Entry | ||
| *[other] { $count } Entries |
There was a problem hiding this comment.
I think this should also be sentence case, since it's not really a title (though this one is less clear, since button labels are title case in Firefox).
There was a problem hiding this comment.
I was basing the decision for title case off of the photon design guidelines, here: http://design.firefox.com/photon/copy/capitalization.html
| item-summary-no-username = (no username) | ||
| item-summary-new-item = New Entry | ||
| item-summary-no-title = (No Entry Name) | ||
| item-summary-no-username = (No Username) |
There was a problem hiding this comment.
Not sure about title case here... Maybe we really just need some CSS to style these specially, like as italic or something?
There was a problem hiding this comment.
I've dealt with too much internationalization concerns elsewhere to not feel confident with CSS directives here (e.g., Turkish dotless i). Maybe I shouldn't be so concerned, but I'd rather start with the strings matching the mockups directly.
There was a problem hiding this comment.
That's fine; I was just thinking about greying them out a bit or something to indicate that they're not human-entered.
There was a problem hiding this comment.
The italics or color change seems like something we can follow up on ... this text matches the invision mockup + how @changecourse (and I) interpret the Photon guidelines.
|
@jimporter @changecourse latest commit should address your concerns ... would you confirm? |
|
Thank you all for working together and getting this over the finish line!
|
Fast follow work from #154 related to #138
(will rebase to get this cleaned up)