refactor(neon_framework): migrate to neon_storage #2529
+1,362
−990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikolas Rimikis <[email protected]>
This is temporary and the long term goal is to remove most of these classes as the framework transitions to direct sqlite access. Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2529 +/- ##
==========================================
+ Coverage 28.66% 28.69% +0.02%
==========================================
Files 366 369 +3
Lines 136296 136370 +74
==========================================
+ Hits 39076 39137 +61
- Misses 97220 97233 +13
*This pull request uses carry forward flags. Click here to find out more.
|
Leptopoda
changed the title
Leptopoda
changed the title
provokateurin
requested changes
Oct 18, 2024
|
|
||
| /// Column for the [Credentials.serverURL]. | ||
| @protected | ||
| static const String serverURL = 'server_urlL'; |
There was a problem hiding this comment.
Suggested change
| static const String serverURL = 'server_urlL'; | |
| static const String serverURL = 'server_url'; |
Comment on lines
-1340
to
-1347
| sqflite: | ||
| dependency: transitive | ||
| description: | ||
| name: sqflite | ||
| sha256: a43e5a27235518c03ca238e7b4732cf35eabe863a369ceba6cbefa537a66f16d | ||
| url: "https://pub.dev" | ||
| source: hosted | ||
| version: "2.3.3+1" |
There was a problem hiding this comment.
This is still required for Android/iOS
| await database.close(); | ||
| }); | ||
|
|
||
| test('throws when unutilized', () async { |
There was a problem hiding this comment.
Suggested change
| test('throws when unutilized', () async { | |
| test('throws when uninitialized', () async { |
|
|
||
| expect( | ||
| persistence.getValue('key'), | ||
| equals('value'), |
There was a problem hiding this comment.
Suggested change
| equals('value'), | |
| 'value', |
Comment on lines
+27
to
+28
| PRIMARY KEY("prefix","key"), | ||
| UNIQUE("key","prefix") |
There was a problem hiding this comment.
Suggested change
| PRIMARY KEY("prefix","key"), | |
| UNIQUE("key","prefix") | |
| PRIMARY KEY("prefix", "key") |
PRIMARY KEY is already UNIQUE
Comment on lines
+16
to
+30
| /// Column for the [Credentials.serverURL]. | ||
| @protected | ||
| static const String serverURL = 'server_urlL'; | ||
|
|
||
| /// Column for the [Credentials.username]. | ||
| @protected | ||
| static const String loginName = 'login_name'; | ||
|
|
||
| /// Column for the [Credentials.appPassword]. | ||
| @protected | ||
| static const String appPassword = 'app_password'; | ||
|
|
||
| /// Column to store the active account. | ||
| @protected | ||
| static const String active = 'active'; |
There was a problem hiding this comment.
Can you pre- or suffix these with column?
| "$serverURL" TEXT NOT NULL, | ||
| "$loginName" TEXT NOT NULL, | ||
| "$appPassword" TEXT, | ||
| "$active" BOOLEAN NOT NULL DEFAULT 0, |
There was a problem hiding this comment.
We should store this separately as it is not really an information about the account itself.
Also there is no check that two accounts can not be active at the same time.
| return credentials.build(); | ||
| } on DatabaseException catch (error, stackTrace) { | ||
| _log.warning( | ||
| 'Error loading cookies.', |
There was a problem hiding this comment.
Wrong error message (same for all other catch blocks in this class)
There was a problem hiding this comment.
How does it work without the platform specific initialization?
There was a problem hiding this comment.
The neon_storage package handles this with a conditional import/export.
We can not easily run the neon_storage tests on web but I'll verify again that this actually works.
provokateurin
requested changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nikolas Rimikis [email protected]