Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(neon_framework): migrate to neon_storage #2529

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+1,362 −990

refactor(account_repository): migrate to neon_storage

b7d8a42
Select commit
Loading
Failed to load commit list.
Open

refactor(neon_framework): migrate to neon_storage #2529

refactor(account_repository): migrate to neon_storage
b7d8a42
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 29, 2024 in 0s

28.69% (+0.02%) compared to 29f6a4b

View this Pull Request on Codecov

28.69% (+0.02%) compared to 29f6a4b

Details

Codecov Report

Attention: Patch coverage is 74.21384% with 41 lines in your changes missing coverage. Please review.

Project coverage is 28.69%. Comparing base (29f6a4b) to head (b7d8a42).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../neon_framework/lib/src/storage/neon_cache_db.dart 0.00% 13 Missing ⚠️
...es/account_repository/lib/src/account_storage.dart 85.52% 11 Missing ⚠️
...s/neon_framework/lib/src/storage/neon_data_db.dart 0.00% 10 Missing ⚠️
...eon_framework/lib/src/storage/storage_manager.dart 0.00% 6 Missing ⚠️
...age/lib/src/storage/sqlite_cookie_persistence.dart 92.30% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2529      +/-   ##
==========================================
+ Coverage   28.66%   28.69%   +0.02%     
==========================================
  Files         366      369       +3     
  Lines      136296   136370      +74     
==========================================
+ Hits        39076    39137      +61     
- Misses      97220    97233      +13
Files with missing lines Coverage Δ
...ackages/neon_framework/lib/src/blocs/accounts.dart 0.00% <ø> (ø)
...ges/neon_framework/lib/src/blocs/first_launch.dart 0.00% <ø> (ø)
...n_framework/lib/src/models/app_implementation.dart 0.00% <ø> (ø)
...lib/src/settings/utils/settings_export_helper.dart 100.00% <ø> (ø)
...neon_framework/lib/src/storage/settings_store.dart 84.61% <ø> (ø)
..._framework/lib/src/storage/single_value_store.dart 100.00% <ø> (ø)
packages/neon_framework/lib/src/testing/mocks.dart 91.66% <ø> (-0.65%) ⬇️
...s/neon_framework/lib/src/utils/global_options.dart 0.00% <ø> (ø)
.../neon_framework/lib/src/utils/request_manager.dart 78.04% <100.00%> (+0.54%) ⬆️
...account_repository/lib/src/account_repository.dart 100.00% <100.00%> (ø)
... and 11 more

... and 2 files with indirect coverage changes

View more details on Codecov