Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Sentieon Docs #1579

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Update Sentieon Docs #1579

wants to merge 4 commits into from
+12 −0

Conversation

edmundmiller
Copy link
Contributor

@edmundmiller edmundmiller commented Jul 1, 2024 •
edited
Loading

Waiting until we get #1380 up and running.

@edmundmiller edmundmiller self-assigned this Jul 1, 2024
@edmundmiller edmundmiller added this to the 3.5 milestone Jul 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit c332140

+| ✅ 200 tests passed       |+
#| ❔  12 tests were ignored |#
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: conf/modules.config
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: assets/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_dark.png
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore
  • actions_ci - actions_ci
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/sarek/sarek/.github/workflows/awstest.yml
  • template_strings - template_strings
  • modules_config - modules_config

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-09-19 21:51:19

@edmundmiller edmundmiller mentioned this pull request Jul 16, 2024
Merged
@FriederikeHanssen FriederikeHanssen removed this from the 3.5 milestone Aug 19, 2024
FriederikeHanssen
FriederikeHanssen previously approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sentieon server is up and running so I think we can merge this.

I have only tested out adding a env config

env {
    SENTIEON_LICENSE = 'IP:PORT'
}

without the secrets, but this works great

@edmundmiller edmundmiller marked this pull request as ready for review August 21, 2024 22:40
@maxulysse
Copy link
Member

Can you update CHANGELOG?

@edmundmiller
Copy link
Contributor Author

@maxulysse As you wish!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen left review comments

@maxulysse maxulysse Awaiting requested review from maxulysse maxulysse is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@edmundmiller edmundmiller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edmundmiller @maxulysse @FriederikeHanssen