Fix ToC building from H2's when the H2 has an extra tag #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker build and CI were broken with the error message: Step 5/31 : RUN apk add closure-compiler --update-cache --repository http://dl-3.alpinelinux.org/alpine/edge/testing/ --allow-untrusted && rm -f /tmp/* /etc/apk/cache/* /root/.cache ---> Running in 550968f4fc23 fetch http://dl-3.alpinelinux.org/alpine/edge/testing/x86_64/APKINDEX.tar.gz ERROR: unable to select packages: closure-compiler (no such package): required by: world[closure-compiler] I'm not entirely sure what the effects of removing this package and no longer cleaning the javascript with it are: I suspect it is not critical -- increased javascript size, potentially missing a few optimisations. There are links in Google search to https://pkgs.alpinelinux.org/package/edge/testing/x86/closure-compiler with text suggesting a v20171203-r1 version existed, but the page itself 404s. A link does exist in the AUR (https://aur.archlinux.org/packages/closure-compiler) Some notes on next steps to try to reintegrate closure-compiler at #702 (comment)
…ag such as bold - The ticket specifically highlights issue if the heading is both H2 and bold. - This will only handle one extra tag with the H2 element - Resolves: https://dxw.zendesk.com/agent/tickets/15382
brent-dxw
force-pushed
the
fix/15382-h2-bold-headings-issue
branch
from
a29ceda
to
41f5ad0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ticket specifically highlights issue if the heading is both H2 and bold.
This should handle any one but only only one extra tag with the H2 element
Resolves: https://dxw.zendesk.com/agent/tickets/15382