Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ToC building from H2's when the H2 has an extra tag #698

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Commits on May 27, 2022

  1. Remove closure-compiler

    Docker build and CI were broken with the error message:
    
    Step 5/31 : RUN apk add closure-compiler --update-cache --repository http://dl-3.alpinelinux.org/alpine/edge/testing/ --allow-untrusted &&     rm -f /tmp/* /etc/apk/cache/* /root/.cache
     ---> Running in 550968f4fc23
    fetch http://dl-3.alpinelinux.org/alpine/edge/testing/x86_64/APKINDEX.tar.gz
    ERROR: unable to select packages:
      closure-compiler (no such package):
        required by: world[closure-compiler]
    
    I'm not entirely sure what the effects of removing this package and no longer cleaning the javascript with
    it are: I suspect it is not critical -- increased javascript size, potentially missing a few optimisations.
    
    There are links in Google search to https://pkgs.alpinelinux.org/package/edge/testing/x86/closure-compiler
    with text suggesting a v20171203-r1 version existed, but the page itself 404s. A link does exist in the
    AUR (https://aur.archlinux.org/packages/closure-compiler)
    
    Some notes on next steps to try to reintegrate closure-compiler at #702 (comment)
    dragon-dxw committed May 27, 2022
    Configuration menu
    Copy the full SHA
    fd0f6ae View commit details
    Browse the repository at this point in the history

Commits on May 30, 2022

  1. Fix TOC building from H2's when the H2 has an additional formatting t…

    …ag such as bold
    
    - The ticket specifically highlights issue if the heading is both H2 and bold.
    - This will only handle one extra tag with the H2 element
    
    - Resolves: https://dxw.zendesk.com/agent/tickets/15382
    brent-dxw committed May 30, 2022
    Configuration menu
    Copy the full SHA
    41f5ad0 View commit details
    Browse the repository at this point in the history