features/48-icon-editor-launcher-behavior-change #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 17, 2024 15:02
This VI gets loaded by default if no compatible custom UI is selected It is a copy of lv_icon.vi
…y with other elements
…ersion of the editor
svelderrainruiz
changed the title
svelderrainruiz
added
enhancement
svelderrainruiz
commented
Oct 18, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
svelderrainruiz
commented
Oct 18, 2024
There was a problem hiding this comment.
Contains the default UI for the icon editor
renamed type specifier strict typedef to a shorter name Reverted back to original connector pane on type specifier
…d up. Changed to use running asynchronously using call and collect. If user aborts now, then the color icon editor shows up
svelderrainruiz
commented
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When icon editor loads, it looks for an entry from the LabVIEW.ini called IconEditorCustomPluginPath
This entry has to be manually added, it is used to place a path to a VI that the icon editor will launch using call and collect
This new behavior of lv_icon relies on handling the error to be able to launch the default icon editor