Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable Blazor linting #1283

Merged
merged 11 commits into from
Jun 6, 2023
Merged

Re-enable Blazor linting #1283

merged 11 commits into from
Jun 6, 2023

Conversation

msmithNI
Copy link
Contributor

@msmithNI msmithNI commented Jun 2, 2023

Pull Request

🀨 Rationale

#1280

πŸ‘©β€πŸ’» Implementation

It looks like a the build agent began pulling in a new version of the .NET tools. dotnet --info prints out this for the CI build:

.NET SDKs installed:
  6.0.408 [/usr/share/dotnet/sdk]
  7.0.105 [/usr/share/dotnet/sdk]
  7.0.203 [/usr/share/dotnet/sdk]
  7.0.302 [/usr/share/dotnet/sdk]

So I'm guessing that 7.0.302 is causing issues.

I found dotnet/format#1800 which is pretty close to what we're seeing. This comment makes it sound like there'll be a newer 7.0.3xx version that will fix this problem, but the issue is still open so I guess that version isn't out yet.
Also see dotnet/format#1834 and dotnet/sdk#32598 which reference 7.0.302 and the DLL v4.6.0.0 specifically.

Changes in this PR:

  • Re-enable Blazor C# linting in package.json
  • Add a global.json file to ensure the dotnet commands are using .NET 6.0.xxx tooling.
    • This will ensure both the CI and local builds are using the .NET 6 SDK for the dotnet CLI commands
  • Add a pipeline step to print out dotnet --info, which will print out all the installed .NET SDK versions, which should make it easier to debug issues like this in the future
  • Update docs to explicitly call out that a .NET SDK install 6.0.202 <= v < 7 is required
  • Update the CI build (main.yml) setup-dotnet action to refer to global.json to get the required .NET version to install (so we're not encoding the required version in multiple places in code)

πŸ§ͺ Testing

CI build + re-built locally.

βœ… Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@msmithNI msmithNI marked this pull request as ready for review June 2, 2023 22:44
.github/workflows/main.yml Outdated Show resolved Hide resolved
@msmithNI msmithNI marked this pull request as draft June 5, 2023 20:59
@msmithNI msmithNI marked this pull request as ready for review June 5, 2023 21:39
@msmithNI msmithNI requested a review from rajsite June 5, 2023 21:40
packages/nimble-blazor/CONTRIBUTING.md Outdated Show resolved Hide resolved
packages/nimble-blazor/README.md Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
@rajsite rajsite merged commit 717b586 into main Jun 6, 2023
@rajsite rajsite deleted the blazor-linting branch June 6, 2023 14:23
@atmgrifter00 atmgrifter00 mentioned this pull request Mar 27, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants