-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable Blazor linting #1283
Merged
Merged
Re-enable Blazor linting #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajsite
reviewed
Jun 5, 2023
β¦l to use same .NET version as global.json explicitly.
rajsite
approved these changes
Jun 5, 2023
change/@ni-nimble-blazor-d4f88529-2aa9-48d9-b605-1eb45277fd1e.json
Outdated
Show resolved
Hide resolved
jattasNI
approved these changes
Jun 5, 2023
atmgrifter00
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π€¨ Rationale
#1280
π©βπ» Implementation
It looks like a the build agent began pulling in a new version of the .NET tools.
dotnet --info
prints out this for the CI build:So I'm guessing that 7.0.302 is causing issues.
I found dotnet/format#1800 which is pretty close to what we're seeing. This comment makes it sound like there'll be a newer 7.0.3xx version that will fix this problem, but the issue is still open so I guess that version isn't out yet.
Also see dotnet/format#1834 and dotnet/sdk#32598 which reference 7.0.302 and the DLL v4.6.0.0 specifically.
Changes in this PR:
dotnet
commands are using .NET 6.0.xxx tooling.dotnet
CLI commandsdotnet --info
, which will print out all the installed .NET SDK versions, which should make it easier to debug issues like this in the future6.0.202 <= v < 7
is requiredmain.yml
)setup-dotnet
action to refer to global.json to get the required .NET version to install (so we're not encoding the required version in multiple places in code)π§ͺ Testing
CI build + re-built locally.
β Checklist