Remove -w dupbuild completely, always error on duplicate edges
#2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digit-google
reviewed
Dec 5, 2023
JeffyCN
added a commit
to JeffyCN/meta-rockchip
that referenced
this pull request
May 8, 2024
The '-w dupbuild' has been removed in newest ninja see ninja-build/ninja#2356 Change-Id: I1303a1e4aa85550667ced33184c929d0a691f16f Signed-off-by: Jeffy Chen <[email protected]>
birunts
added a commit
to ARM-software/bob-build
that referenced
this pull request
Sep 19, 2024
Newer ninja vesrions do not support `dupbuild` flag anymore: ninja-build/ninja#2356 Put `dupbuild` flag only if ninja supports it. This forces to apply patch on archived `blueprint` submodule. Change-Id: I0210375bb1b5f23b3a6bb3cfe8674ed08d98a6ae Signed-off-by: Sebastian Birunt <[email protected]>
birunts
added a commit
to ARM-software/bob-build
that referenced
this pull request
Sep 19, 2024
Newer ninja vesrions do not support `dupbuild` flag anymore: ninja-build/ninja#2356 Put `dupbuild` flag only if ninja supports it. This forces to apply patch on archived `blueprint` submodule. Change-Id: I0210375bb1b5f23b3a6bb3cfe8674ed08d98a6ae Signed-off-by: Sebastian Birunt <[email protected]>
birunts
added a commit
to ARM-software/bob-build
that referenced
this pull request
Oct 7, 2024
Newer `ninja-build` does not have `dupbuild` warning flag anymore: ninja-build/ninja#2356
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 5, fixes #931.