Fix for #2520: Force C++11 for MacOS CI builder. #2521
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MacOS CI builders use a compiler which defaults to C++03. Unfortunately, CMakeLists.txt only forces C++11 for libninja, try to force it through CMAKE_CXX_STANDARD. Note a few interesting points: - Tests use GoogleTest which officially *requires* C++14. However, it seems that compiling them with C++03 or C++11 doesn´t seem to be an issue on this platform for now. - To avoid future problems, it might be useful to enforce a separate default of C++14 for test programs. - GoogleTest plans to switch to C++17 in December 2024 [1], [1] https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md
|
Enabling C++11 should be done in the CMakeLists.txt instead, so users don't have to pass btw: We are using the last GoogleTest that supports C++11, so no need for bumping further. |
|
Oh I see, I'll upload a different PR then, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MacOS CI builders use a compiler which defaults to C++03. Unfortunately, CMakeLists.txt only forces C++11 for libninja, try to force it through CMAKE_CXX_STANDARD.
Note a few interesting points:
Tests use GoogleTest which officially requires C++14. However, it seems that compiling them with C++03 or C++11 doesn´t seem to be an issue on this platform for now.
To avoid future problems, it might be useful to enforce a separate default of C++14 for test programs.
GoogleTest plans to switch to C++17 in December 2024 [1],
[1] https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md