Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #2520: Force C++11 for MacOS CI builder. #2521

Commits on Nov 4, 2024

  1. Fix for ninja-build#2520: Force C++11 for MacOS CI builder.

    MacOS CI builders use a compiler which defaults to C++03.
    Unfortunately, CMakeLists.txt only forces C++11 for libninja,
    try to force it through CMAKE_CXX_STANDARD.
    
    Note a few interesting points:
    
    - Tests use GoogleTest which officially *requires* C++14.
      However, it seems that compiling them with C++03 or C++11
      doesn´t seem to be an issue on this platform for now.
    
    - To avoid future problems, it might be useful to enforce
      a separate default of C++14 for test programs.
    
    - GoogleTest plans to switch to C++17 in December 2024 [1],
    
    [1] https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md
    digit-google committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    44ebf2f View commit details
    Browse the repository at this point in the history