Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: combobox React package #2453

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

feat: combobox React package #2453

wants to merge 18 commits into from

Conversation

AliKdhim87
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Aug 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
utrecht ❌ Failed (Inspect) Sep 17, 2024 0:07am

@Robbert Robbert changed the title wip feat: combobox React package Aug 31, 2024
@AliKdhim87 AliKdhim87 force-pushed the feat/create-comboxbox branch 3 times, most recently from 970c5b9 to e33e4bb Compare September 2, 2024 14:48
@AliKdhim87 AliKdhim87 force-pushed the feat/create-comboxbox branch 3 times, most recently from a72fc77 to aa33062 Compare September 3, 2024 12:06
@AliKdhim87 AliKdhim87 marked this pull request as ready for review September 3, 2024 12:07
@AliKdhim87 AliKdhim87 force-pushed the feat/create-comboxbox branch 2 times, most recently from c884c8c to 1be5184 Compare September 3, 2024 12:28
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 96.73913% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.81%. Comparing base (d9a5161) to head (0d34140).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ibrary-react/packages/combobox-react/src/index.tsx 91.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2453      +/-   ##
==========================================
- Coverage   97.82%   97.81%   -0.02%     
==========================================
  Files         150      154       +4     
  Lines        1152     1190      +38     
  Branches      231      236       +5     
==========================================
+ Hits         1127     1164      +37     
- Misses         24       25       +1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The new classes:

- `utrecht-combobox__textbox-container`
- `utrecht-combobox__toggle-button`

  ```CSS
  --utrecht-combobox-toggle-button-background-color: transparent; //default value
  --utrecht-combobox-toggle-button-color: currentColor; //default value
  --utrecht-combobox-toggle-button-hover-background-color: transparent; //default value
  --utrecht-combobox-toggle-button-hover-color: currentColor; //default value
  --utrecht-combobox-toggle-button-active-background-color: transparent; //default value
  --utrecht-combobox-toggle-button-active-color: currentColor; //default value
  --utrecht-combobox-toggle-button-focus-background-color: transparent; //default value
  --utrecht-combobox-toggle-button-focus-color: currentColor; //default value
  --utrecht-combobox-toggle-button-pressed-background-color: transparent; //default value
  --utrecht-combobox-toggle-button-pressed-color: currentColor; //default value
  ```

- `utrecht-combobox__icon`

  ```CSS
  --utrecht-combobox-icon-size: 32px; //default value
  ```

- name: "Continuous Integration: build"
run: |
pnpm run --if-present build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product-metadata heeft select-component om Uniforme Productnaam te kiezen
2 participants