generated from nl-design-system/example
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: combobox React package #2453
Open
AliKdhim87
wants to merge
18
commits into
main
Choose a base branch
from
feat/create-comboxbox
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b6386ad
fix: resolve style issue with react-button component when imported fr…
AliKdhim87 e1007d0
feat: create the rest CSS classes for the combobox elements
AliKdhim87 8b26d2c
fix: fix the listbox width on small screens
AliKdhim87 2813cdf
feat: create React combobox component
AliKdhim87 4046378
feat: re-export the new React-Combobox
AliKdhim87 c94c1bb
feat: create form-field-react package
AliKdhim87 f5fa31e
feat: re-export FormField-react component
AliKdhim87 5e9afb9
feat: create FormLabel react component package
AliKdhim87 0cfabb4
feat: re-export FormLabel-react component
AliKdhim87 3e55539
feat: create React-listbox component package
AliKdhim87 c7895ed
feat: create React Textbox component package
AliKdhim87 3f4b408
feat: re-export React `Listbox` component package
AliKdhim87 29e138b
feat: re-export React Textbox component package
AliKdhim87 855e3ae
docs: add Combobox stories
AliKdhim87 eab76ce
chore: create ComboboxPopoverProps interface
AliKdhim87 7576581
feat: create `FormFieldCombobox` react package
AliKdhim87 df56068
feat: re-export `FormFieldCombobox` component package
AliKdhim87 0d34140
test: fix test issue
AliKdhim87 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@utrecht/listbox-react": major | ||
--- | ||
|
||
Create React-listbox component package |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@utrecht/textbox-react": minor | ||
--- | ||
|
||
Re-export React Textbox component package |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
"@utrecht/component-library-react": patch | ||
"@utrecht/button-react": patch | ||
"@utrecht/calendar-react": patch | ||
--- | ||
|
||
Fix the button style issue when importing it from `dist/css-module`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
--- | ||
"@utrecht/combobox-css": minor | ||
--- | ||
|
||
Create the rest CSS classes for the combobox elements. | ||
|
||
The new classes: | ||
|
||
- `utrecht-combobox__textbox-container` | ||
- `utrecht-combobox__toggle-button` | ||
|
||
```CSS | ||
--utrecht-combobox-toggle-button-background-color: transparent; //default value | ||
--utrecht-combobox-toggle-button-color: currentColor; //default value | ||
--utrecht-combobox-toggle-button-hover-background-color: transparent; //default value | ||
--utrecht-combobox-toggle-button-hover-color: currentColor; //default value | ||
--utrecht-combobox-toggle-button-active-background-color: transparent; //default value | ||
--utrecht-combobox-toggle-button-active-color: currentColor; //default value | ||
--utrecht-combobox-toggle-button-focus-background-color: transparent; //default value | ||
--utrecht-combobox-toggle-button-focus-color: currentColor; //default value | ||
--utrecht-combobox-toggle-button-pressed-background-color: transparent; //default value | ||
--utrecht-combobox-toggle-button-pressed-color: currentColor; //default value | ||
``` | ||
|
||
- `utrecht-combobox__icon` | ||
|
||
```CSS | ||
--utrecht-combobox-icon-size: 32px; //default value | ||
``` | ||
|
||
- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@utrecht/storybook-react": minor | ||
--- | ||
|
||
Add Combobox stories |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@utrecht/component-library-react": minor | ||
--- | ||
|
||
Re-export FormLabel-react component |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@utrecht/component-library-react": minor | ||
--- | ||
|
||
Re-export `FormFieldCombobox` component package |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@utrecht/combobox-react": major | ||
--- | ||
|
||
Create React combobox component |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@utrecht/form-field-react": major | ||
--- | ||
|
||
Create form-field-react package |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@utrecht/listbox-css": patch | ||
--- | ||
|
||
Fix the listbox width on small screens |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@utrecht/component-library-react": minor | ||
--- | ||
|
||
Re-export React Listbox component package |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@utrecht/form-field-combobox-react": major | ||
--- | ||
|
||
Create `FormFieldCombobox` react package |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@utrecht/form-label-react": major | ||
--- | ||
|
||
Create FormLabel react component package |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@utrecht/component-library-react": minor | ||
--- | ||
|
||
Re-export the new React-Combobox |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@utrecht/component-library-react": minor | ||
--- | ||
|
||
Re-export FormField-react component |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@utrecht/textbox-react": major | ||
--- | ||
|
||
Create React Textbox component package |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,162 @@ | ||
{ | ||
"utrecht": { | ||
"combobox": { | ||
"max-inline-size": { | ||
"$extensions": { | ||
"nl.nldesignsystem.css.property": { | ||
"syntax": "<length>", | ||
"inherits": true | ||
}, | ||
"nl.nldesignsystem.figma.supports-token": true | ||
}, | ||
"type": "spacing" | ||
}, | ||
"border-color": { | ||
"$extensions": { | ||
"nl.nldesignsystem.css.property": { | ||
"syntax": "<color>", | ||
"inherits": true | ||
}, | ||
"nl.nldesignsystem.figma.supports-token": true | ||
}, | ||
"type": "color" | ||
}, | ||
"input": { | ||
"container": { | ||
"inline-size": { | ||
"$extensions": { | ||
"nl.nldesignsystem.css.property": { | ||
"syntax": "<length>", | ||
"inherits": true | ||
}, | ||
"nl.nldesignsystem.figma.supports-token": true | ||
}, | ||
"type": "spacing" | ||
} | ||
} | ||
}, | ||
"toggle-button": { | ||
"background-color": { | ||
"$extensions": { | ||
"nl.nldesignsystem.css.property": { | ||
"syntax": "<color>", | ||
"inherits": true | ||
}, | ||
"nl.nldesignsystem.figma.supports-token": true | ||
}, | ||
"type": "color" | ||
}, | ||
"color": { | ||
"$extensions": { | ||
"nl.nldesignsystem.css.property": { | ||
"syntax": "<color>", | ||
"inherits": true | ||
}, | ||
"nl.nldesignsystem.figma.supports-token": true | ||
}, | ||
"type": "color" | ||
}, | ||
"hover": { | ||
"background-color": { | ||
"$extensions": { | ||
"nl.nldesignsystem.css.property": { | ||
"syntax": "<color>", | ||
"inherits": true | ||
}, | ||
"nl.nldesignsystem.figma.supports-token": true | ||
}, | ||
"type": "color" | ||
}, | ||
"color": { | ||
"$extensions": { | ||
"nl.nldesignsystem.css.property": { | ||
"syntax": "<color>", | ||
"inherits": true | ||
}, | ||
"nl.nldesignsystem.figma.supports-token": true | ||
}, | ||
"type": "color" | ||
} | ||
}, | ||
"active": { | ||
"background-color": { | ||
"$extensions": { | ||
"nl.nldesignsystem.css.property": { | ||
"syntax": "<color>", | ||
"inherits": true | ||
}, | ||
"nl.nldesignsystem.figma.supports-token": true | ||
}, | ||
"type": "color" | ||
}, | ||
"color": { | ||
"$extensions": { | ||
"nl.nldesignsystem.css.property": { | ||
"syntax": "<color>", | ||
"inherits": true | ||
}, | ||
"nl.nldesignsystem.figma.supports-token": true | ||
}, | ||
"type": "color" | ||
} | ||
}, | ||
"focus": { | ||
"background-color": { | ||
"$extensions": { | ||
"nl.nldesignsystem.css.property": { | ||
"syntax": "<color>", | ||
"inherits": true | ||
}, | ||
"nl.nldesignsystem.figma.supports-token": true | ||
}, | ||
"type": "color" | ||
}, | ||
"color": { | ||
"$extensions": { | ||
"nl.nldesignsystem.css.property": { | ||
"syntax": "<color>", | ||
"inherits": true | ||
}, | ||
"nl.nldesignsystem.figma.supports-token": true | ||
}, | ||
"type": "color" | ||
} | ||
}, | ||
"pressed": { | ||
"background-color": { | ||
"$extensions": { | ||
"nl.nldesignsystem.css.property": { | ||
"syntax": "<color>", | ||
"inherits": true | ||
}, | ||
"nl.nldesignsystem.figma.supports-token": true | ||
}, | ||
"type": "color" | ||
}, | ||
"color": { | ||
"$extensions": { | ||
"nl.nldesignsystem.css.property": { | ||
"syntax": "<color>", | ||
"inherits": true | ||
}, | ||
"nl.nldesignsystem.figma.supports-token": true | ||
}, | ||
"type": "color" | ||
} | ||
} | ||
}, | ||
"icon": { | ||
"size": { | ||
"$extensions": { | ||
"nl.nldesignsystem.css.property": { | ||
"syntax": "<length>", | ||
"inherits": true | ||
}, | ||
"nl.nldesignsystem.figma.supports-token": true | ||
}, | ||
"type": "spacing" | ||
} | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?