adjust warnings for 2DAR #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rick-Methot-NOAA
requested review from
kellijohnson-NOAA and
iantaylor-NOAA
and removed request for
kellijohnson-NOAA
iantaylor-NOAA
approved these changes
Sep 13, 2024
Rick-Methot-NOAA
deleted the
615-bug-rho-parameters-not-impacting-semi-parametric-2d-ar-selectivity-when-multiple-sigma-values-are-used
branch
|
@e-perl-NOAA Please reflect these revised warnings into the manual. |
| } | ||
| if (use_rho == 1) | ||
| { | ||
| echoinput << "read two parameter lines for rho_yr and then rho_age (or length)" << endl; | ||
| warnstream << "2DAR rho is incompletely implemented; it should only be used experimentally and never estimated"; |
There was a problem hiding this comment.
I am hesitant to allow users to even do this if it is incompletely implemented. I would prefer a full stop if use_rho = 1. Especially because in this same if statement you set dtempvec(7) = -1. Which, does that just change the values put in ss_new or does it actually turn off estimation without the user knowing?
There was a problem hiding this comment.
The estimation has never been enabled. The value of rho is only used in the preliminary calcs section to create a cor matrix.
Rick-Methot-NOAA
restored the
615-bug-rho-parameters-not-impacting-semi-parametric-2d-ar-selectivity-when-multiple-sigma-values-are-used
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concisely describe what has been changed/addressed in the pull request.
Find that the rho feature of 2DAR was incompletely implemented and a full fix is not feasible at this time. Provide new warnings and guidance to users.
What tests have been done?
Numerous runs with various permutations of estimating or fixing age-specific sigmasel values using hake 2DAR example.
Where are the relevant files?
What tests/review still need to be done?
none
Is there an input change for users to Stock Synthesis?
Additional information (optional).