Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip crashing shortfin python tests on Windows. #289

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

ScottTodd
Copy link
Member

Follow-up to #269.

Something about this error handling is crashing the process without useful logs: https://github.com/nod-ai/SHARK-Platform/actions/runs/11373400662/job/31639876327?pr=288#step:9:131

Until we can debug that further, skip the affected tests on Windows.

Copy link
Collaborator

@marbre marbre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Scott.

Should we fill an issue to keep track of what needs to get fixed at some point?

@ScottTodd ScottTodd enabled auto-merge (squash) October 17, 2024 14:44
@ScottTodd ScottTodd merged commit 95792af into nod-ai:main Oct 17, 2024
8 of 9 checks passed
@ScottTodd ScottTodd deleted the shortfin-windows-pytest branch October 17, 2024 14:46
@ScottTodd
Copy link
Member Author

Should we fill an issue to keep track of what needs to get fixed at some point?

Filed #295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants