Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip crashing shortfin python tests on Windows. #289

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Skip crashing shortfin python tests on Windows. #289

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6f7a88
Skip crashing shortfin python tests on Windows.
ScottTodd Oct 16, 2024
0789535
Merge branch 'main' into shortfin-windows-pytest
ScottTodd Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions shortfin/tests/api/array_storage_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception

import pytest
import sys

import shortfin as sf
import shortfin.array as sfnp
Expand Down Expand Up @@ -68,6 +69,9 @@ async def main():
lsys.run(main())


@pytest.mark.skipif(
sys.platform == "win32", reason="Windows fatal exception: access violation"
)
def test_fill_error(device):
s = sfnp.storage.allocate_host(device, 8)
with pytest.raises(RuntimeError):
Expand All @@ -80,6 +84,9 @@ def test_fill_error(device):
s.fill(b"01234567")


@pytest.mark.skipif(
sys.platform == "win32", reason="Windows fatal exception: access violation"
)
@pytest.mark.parametrize(
"pattern,size",
[
Expand Down
Loading