Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add remark-gfm #5978

Merged
merged 1 commit into from
Oct 10, 2023
Merged

fix: add remark-gfm #5978

merged 1 commit into from
Oct 10, 2023

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Oct 10, 2023

Description

This PR adds remark-gfm back. But forcefully on the version 3.0; We shouldn't update to version 4.0 until gets addressed hashicorp/next-mdx-remote#403

IMPORTANT to mention that we should stick with v3 for now

Validation

Features from RemarkGFM such as AutoLinks should be working.

Related Issues

Fixes #5977

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@ovflowd ovflowd requested review from a team as code owners October 10, 2023 18:01
@vercel
Copy link

vercel bot commented Oct 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Oct 10, 2023 6:01pm

@github-actions
Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 94%
92.9% (262/282) 78.12% (50/64) 89.47% (51/57)

Unit Test Report

Tests Skipped Failures Errors Time
27 0 💤 0 ❌ 0 🔥 8.155s ⏱️

@ovflowd
Copy link
Member Author

ovflowd commented Oct 10, 2023

cc @nodejs/nodejs-website for fast-track

@ovflowd ovflowd disabled auto-merge October 10, 2023 20:43
@ovflowd ovflowd merged commit e7d6e09 into main Oct 10, 2023
18 of 19 checks passed
@ovflowd ovflowd deleted the fix/add-remark-gfm branch October 10, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download links are not links on release posts
2 participants