chore: create base eslint config #7057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
araujogui
commented
Sep 23, 2024
ovflowd
reviewed
Sep 23, 2024
ovflowd
reviewed
Sep 23, 2024
ovflowd
approved these changes
Sep 23, 2024
aymen94
approved these changes
Sep 24, 2024
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Unit Test Coverage Report
Unit Test Report
|
|
@araujogui do you have time rebase this? sorry it's been getting stale |
araujogui
force-pushed
the
chore/base-eslint
branch
from
fb095b1
to
0ad4e2e
Compare
github-actions
bot
removed
the
github_actions:pull-request
|
@nodejs/nodejs-website reviews pls |
AugustinMauroy
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
LGTM !
As suggested in the turbo documentation, you can also use a package as a basis for the configuration
https://turbo.build/repo/docs/guides/tools/eslint#sharing-configuration
araujogui
force-pushed
the
chore/base-eslint
branch
from
69dffe1
to
fc2d06e
Compare
github-actions
bot
removed
the
github_actions:pull-request
github-actions
bot
removed
the
github_actions:pull-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create base ESLint config
Validation
Well, ESLint works
Related Issues
Related to #5405
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.