chore: document what we want/wan't translate #7350
Open
+27
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
TRANSLATION.md:100
- The heading 'Why We Translate This section and Not this Section' should be 'Why We Translate This Section and Not This Section' for consistent capitalization.
## Why We Translate This section and Not this Section
Co-authored-by: Copilot <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]>
TRANSLATION.md
Outdated
Comment on lines
122
to
123
| - **Blog**: The blog is not translated because it's not useful to translate blog posts. Most of the blog posts are release notes, and it's not useful to translate them. | ||
| - **Learn**: The learn section is not translated because it contains technical terms that are hard to translate. Plus, we don't have the ability to trust the quality of the translations. It's better to have the content in English than to have bad translations. If you want to have more information read [this message](https://github.com/nodejs/nodejs.org/issues/6429#issuecomment-2558265376) that summarizes whole reasons. |
There was a problem hiding this comment.
add that this is a TSC decision
There was a problem hiding this comment.
I know that but idk how to write down that
Co-authored-by: Brian Muenzenmeyer <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]>
bmuenzenmeyer
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
People often ask why the learn section isn't translated, so I've written a bit of a document about it. But I'm not very good at the documentation part. So if anyone knows how to go over my work again, I think it would be beneficial.
The first review should be done by the website team and why not have it validated by the TSC?
Check List
npm run formatto ensure the code follows the style guide.