-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/file upload modal #431
Feat/file upload modal #431
Conversation
@a-crea Thank you for this PR Unfortunately it doesn't satisfy all checks (see https://github.com/noi-techpark/it.bz.opendatahub.databrowser/actions/runs/6563367797/job/17827429525?pr=431) and can therefor not be merged. I think the problems are related to missing REUSE license headers in new files. Please take a look at other existing files and see how such headers look like. Then, please add the header to all related files. |
@a-crea I saw in another PR (#432) that the branch was not up-to-date with the current development branch (see #432 (comment)). The same problem seems to appear in this PR. Please bring your branch up-to-date with the current development branch doing a rebase (or merge if you prefer). It simplifies the code review very much thx |
969522b
to
dc9e8d0
Compare
d216930
to
6a11b60
Compare
@a-crea thank you for this PR There still seems to be a bug, where I'm not able to add languages (see screenshot) Steps to reproduce:
=> the popup appears, but there is no way to add languages In my opinion, all languages should be shown such that a user can select languages that were not selected before There seems to be another (related?) bug, that happens when more than one documents get uploaded. Ifone wants to change the language info without reloading the page, no language is shown at all in the popup Steps to reproduce:
=> the popup appears, but there is no language shown at all Please take a look at these issues, thx |
@MatteoBiasi I had the impression that it should be possible to add languages and #438 was there to discuss if the language assignment should be modified (e.g. provide delete / add buttons). The main problem with this implementation is, that it is impossible to add languages after an upload was saved. @sseppi if the behavior implemented in this PR is fine, we can merge it |
@gappc @MatteoBiasi I agree that the behaviour isn't perfet at the moment, but I need to go online as soon as possible with this new feature. So I would suggest to do compromise, go online with this PR and implement as soon as possibel the changes included in the issue #438 |
@sseppi @MatteoBiasi @a-crea merge is done 👍 |
This pull request includes the new file upload language settings modal.