-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/new fields metadata #432
Feat/new fields metadata #432
Conversation
@a-crea thank you for this PR. Given that the PR changes 66 files, I took a deeper look at it. It seems, that most modifications should not be part of this PR and are related to other work - maybe PR #431 or even PR #429? I would appreciate if you could clean up this PR and provide only the changes necessary for this PR to fulfill its requirements. Otherwise it gets really hard for me to do a proper review thx |
@a-crea thank you for your effort, but still it seems that something is odd. If you take a look at the number of files this PR wants to merge on the top right of this page, you'll see that 78 files wait to be merged. I'm pretty sure that most of those files do not belong to this PR. I also tested to merge this PR locally (on my machine) into the current Would it be possible for you to open a new PR where you apply your changes (and only those)? I think that would be the easiest way to go forward. thx |
bf19a98
to
b99b75e
Compare
b99b75e
to
3037010
Compare
@gappc Hi! |
</template> | ||
|
||
<script setup lang="ts"> | ||
import { computed, toRefs } from 'vue'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@a-crea please remove the import for computed
, it is never used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
@a-crea thank you for the |
@gappc done, let me know :) |
@a-crea I've merged this PR, thx for your work 👍 |
This pull request includes the new metadata fields in list view, detail view, new and edit views. It also contains the new functionality to "ADD NEW" value to existing options.